Skip to content

Fixes for modules at negative eta #14716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njacazio merged 3 commits into from
Oct 3, 2025
Merged

Fixes for modules at negative eta #14716

njacazio merged 3 commits into from
Oct 3, 2025

Conversation

@ekryshen
Copy link
Contributor

@ekryshen ekryshen commented Oct 2, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@njacazio njacazio enabled auto-merge (squash) October 2, 2025 15:34
njacazio
njacazio previously approved these changes Oct 2, 2025
View reviewed changes
@alibuild
Copy link
Collaborator

alibuild commented Oct 2, 2025 •
edited
Loading

Error while checking build/O2/fullCI_slc9 for 33f4a4c at 2025-10-02 19:37:

++ cp /sw/slc9_x86-64/O2/14716-slc9_x86-64-local1/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonpath([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2_SRC=/sw/SOURCES/O2/14716-slc9_x86-64/0
++ [[ -e /sw/SOURCES/O2/14716-slc9_x86-64/0/CMakeLists.txt ]]

Full log here.

auto-merge was automatically disabled October 2, 2025 18:19

Head branch was pushed to by a user without write access

@ekryshen ekryshen marked this pull request as draft October 3, 2025 04:40
@ekryshen ekryshen marked this pull request as ready for review October 3, 2025 04:40
@ekryshen ekryshen requested a review from njacazio October 3, 2025 10:30
@ekryshen
Copy link
Contributor Author

ekryshen commented Oct 3, 2025

@njacazio Unfortunatelly your review was dismissed. Could you review again?

@njacazio njacazio enabled auto-merge (squash) October 3, 2025 11:38
@njacazio njacazio merged commit b1904ff into AliceO2Group:dev Oct 3, 2025
11 checks passed
plariono pushed a commit to plariono/AliceO2 that referenced this pull request Oct 23, 2025
@ekryshen @plariono
Fixes for modules at negative eta (AliceO2Group#14716)
25c253f 
* Fixes for modules at negative eta

* Add braces in if statements

* retrigger checks
bazinski pushed a commit to bazinski/AliceO2 that referenced this pull request Feb 10, 2026
@ekryshen @bazinski
Fixes for modules at negative eta (AliceO2Group#14716)
4dbeae4 
* Fixes for modules at negative eta

* Add braces in if statements

* retrigger checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@njacazio njacazio njacazio approved these changes

@mconcas mconcas Awaiting requested review from mconcas mconcas is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ekryshen @alibuild @njacazio