[EMCAL] implementation of number of local maxima variable#14943
Merged
jokonig merged 5 commits intoAliceO2Group:devfrom Jan 9, 2026
Merged
[EMCAL] implementation of number of local maxima variable#14943jokonig merged 5 commits intoAliceO2Group:devfrom
jokonig merged 5 commits intoAliceO2Group:devfrom
Conversation
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
fjonasALICE
added a commit
to fjonasALICE/AliceO2
that referenced
this pull request
Jan 6, 2026
Please consider the following formatting changes to AliceO2Group#14943
mhemmer-cern
suggested changes
Jan 6, 2026
Please consider the following formatting changes to AliceO2Group#14943
mhemmer-cern
approved these changes
Jan 7, 2026
jokonig
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested locally for:
kV3Default: a few clusters with more than one NLM (as expected)
kV3NoSplit: the definition where average NLM is highest (as expected)
kV3MostSplit: NLM is always one (as expected).
to improve performance and reduce geometry calls, the calculation is performed only once for all cells in a given cluster