Store TPC track A/C side info in the AO2D TrackExtra.fFlags unused bits#15014
Open
shahor02 wants to merge 2 commits intoAliceO2Group:devfrom
Open
Store TPC track A/C side info in the AO2D TrackExtra.fFlags unused bits#15014shahor02 wants to merge 2 commits intoAliceO2Group:devfrom
shahor02 wants to merge 2 commits intoAliceO2Group:devfrom
Conversation
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Contributor
|
Thanks Ruben for the quick implementation — this is exactly what we discussed. Summary: This PR adds TPC side information (A/C/both) to the AO2D track flags. Changes:
Interpretation:
Use cases:
Cost: No AO2D schema change, uses 2 unused bits, ~1 bit effective entropy. === Diff summary was automatically compared with agrrement in matermost discussion Lets merge |
Collaborator
|
No objection. Should this come with dynamic columns for easier use from AO2D, like: |
Collaborator
Contributor
|
It looks good to me too, and I agree with Jan Fiete's point above. |
shahor02
force-pushed
the
pr_aodTPCSide
branch
from
4252000 to
8a165a6
Compare
Contributor
|
Hi everyone, just to say this does look okay to me as well as it is a relatively straightforward addition of 2 bits of information. It's also nice that this doesn't add an extra converter because it uses the existing flags column. In any case, IMHO it might be good to prepare some (very few) slides to present in one of the Monday meetings just as a reference for this change, though in this case I believe we could merge already now if we all agree since the space change is likely rather negligible indeed. Thanks! |
shahor02
force-pushed
the
pr_aodTPCSide
branch
from
8a165a6 to
3d1f32c
Compare
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 3d1f32c at 2026-02-06 05:55: Full log here. |
shahor02
force-pushed
the
pr_aodTPCSide
branch
from
3d1f32c to
ad337a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.