Merged
Conversation
Member
Author
|
We need this to be able to bump to the new protobuf and gRPC (which is needed to be able to bump to the new ONNXRuntime). |
Member
Author
|
@davidrohr as we discussed over coffee. |
Member
Author
|
@knopers8 can we get a new tag with this? |
Collaborator
|
Was this tested? |
Member
Author
|
@justonedev1 The only tests I know about are the CI ones. Of course feel free to do any extra validation before tagging. |
Collaborator
|
This bit is not tested in the CI, one will have to validate this manually. |
knopers8
approved these changes
Mar 19, 2025
Collaborator
knopers8
left a comment
knopers8
left a comment
There was a problem hiding this comment.
Thanks. Given that the RPM builds are not working at the moment, the best I can do is to create a patch release and test it with the FLP suite CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.