[OCTRL-1029] Stop runs upon beam dump#754
Merged
knopers8 merged 3 commits intoAliceO2Group:masterfrom Oct 15, 2025
Merged
Conversation
knopers8
force-pushed
the
stop-run-on-lhc
branch
from
dc2eb1f to
3d9f8e4
Compare
knopers8
changed the title
Collaborator
Author
|
@justonedev1 I confirmed it works, it's ready for review. |
knopers8
force-pushed
the
stop-run-on-lhc
branch
from
3d9f8e4 to
1790592
Compare
knopers8
changed the title
justonedev1
reviewed
Oct 14, 2025
Collaborator
justonedev1
left a comment
justonedev1
left a comment
There was a problem hiding this comment.
are the todos supposed to be left in the code?
core/integration/lhc/plugin.go
Outdated
| func (p *Plugin) GetData(_ []any) string { | ||
| p.mu.Lock() | ||
| defer p.mu.Unlock() | ||
| b, _ := json.Marshal(&p.currentState) // todo see if this works like that |
Collaborator
Author
There was a problem hiding this comment.
it did not, i rewrote it as it is done in the BKP plugin, that works.
core/integration/lhc/plugin.go
Outdated
| } | ||
|
|
||
| func (p *Plugin) Destroy() error { | ||
| // todo add mutex? |
Collaborator
There was a problem hiding this comment.
when is this todo supposed to happen?
Collaborator
Author
I forgot about them, i will address them or remove in this PR. |
A necessary building block for OCTRL-1049
The updates come from ALICE LHC DIP client. Work towards OCTRL-1049. Eventually, this plugin will also allow to get rid of BKP.RetrieveFillInfo call and consume Fill information without going through BKP.
A new "stop_at_beam_dump" flag allows to request an automatic STOP_ACTIVITY when we recognize that LHC dumped beams. Closes OCTRL-1049
knopers8
force-pushed
the
stop-run-on-lhc
branch
from
1790592 to
8e67e58
Compare
Collaborator
Author
|
@justonedev1 it should be all good now. |
justonedev1
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP until we manage to test it with George.