Migrate fill info retrieval to the new LHC plugin#772
Migrate fill info retrieval to the new LHC plugin#772knopers8 merged 1 commit intoAliceO2Group:masterfrom
Conversation
This commit adds a new call in LHC plugin which updates a given environment with the latest known fill information. Once we validate it, we can proceed with switching off the bkp.RetrieveFillInfo() call. A necessary change in workflow template will have to follow. This approach is better, because we don't rely on a man in the middle, thus reduce risks of errors and getting the required info too late (i.e. not before SOR). Closes OCTRL-1057
justonedev1
left a comment
There was a problem hiding this comment.
I approve this but I am not sure whether all of the global variables are set/reset correctly, but I trust you that they are.
However I have one question about timestamps. We are receiving timestamps about beam via kafka, so it means that when we reach stable beam we get new message with stable beam start and no end, right? And when the beam is dumped, we receive what exactly?
From my observations, when SB did not happen, we get "-1" as timestamps: When we enter SB, we get: When the beam is dump, we get both SB start and end: So the "-1" vs. missing optional value is somewhat inconsistent, but we support both cases for missing values. |
This commit adds a new call in LHC plugin which updates a given environment with the latest known fill information. Once we validate it, we can proceed with switching off the bkp.RetrieveFillInfo() call. A necessary change in workflow template will have to follow.
This approach is better, because we don't rely on a man in the middle, thus reduce risks of errors and getting the required info too late (i.e. not before SOR).
Closes OCTRL-1057