[PWGJE] Fix wrong headers. Remove unused files. Fix includes.#14128
Merged
nzardosh merged 20 commits intoAliceO2Group:masterfrom Dec 19, 2025
Merged
[PWGJE] Fix wrong headers. Remove unused files. Fix includes.#14128nzardosh merged 20 commits intoAliceO2Group:masterfrom
nzardosh merged 20 commits intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 425 errors, |
github-actions
bot
changed the title
vkucera
changed the title
vkucera
pushed a commit
to vkucera/O2Physics
that referenced
this pull request
Dec 8, 2025
vkucera
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
vkucera
pushed a commit
to vkucera/O2Physics
that referenced
this pull request
Dec 13, 2025
Collaborator
Author
|
@nzardosh I have validated that |
nzardosh
reviewed
Dec 18, 2025
| Configurable<std::vector<double>> trackingEfficiency{"trackingEfficiency", {1.0, 1.0}, "tracking efficiency array applied to jet finding if applyTrackingEfficiency is true"}; | ||
|
|
||
| Service<o2::framework::O2DatabasePDG> pdg; | ||
| o2::framework::Configurable<float> zCut{"zCut", 0.1, "soft drop z cut"}; |
Collaborator
There was a problem hiding this comment.
what is the benefit of not including these common o2 namespaces in the .h files? it seems to me that every single o2 task needs these namespaces so it just seems it makes the headers more complex to read if we remove them
Collaborator
Author
There was a problem hiding this comment.
using directives are forbidden in the global scope of headers for many important reasons.
Collaborator
|
thanks for checking vit! I am happy with the headers being moved but I am less sure that making the namespaces explicit in the headers is practical. particularly the ones that are used in every single task. |
nzardosh
approved these changes
Dec 19, 2025
sigurdnese
pushed a commit
to sigurdnese/O2Physics
that referenced
this pull request
Jan 9, 2026
…2Group#14128) Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
MattOckleton
pushed a commit
to MattOckleton/O2Physics
that referenced
this pull request
Jan 14, 2026
…2Group#14128) Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
mapalhares
pushed a commit
to mapalhares/O2Physics
that referenced
this pull request
Jan 20, 2026
…2Group#14128) Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
fcolamar
pushed a commit
to fcolamar/O2Physics
that referenced
this pull request
Feb 4, 2026
…2Group#14128) Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
karlazertova
pushed a commit
to karlazertova/O2Physics
that referenced
this pull request
Feb 5, 2026
…2Group#14128) Co-authored-by: ALICE Builder <alibuild@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cxxfiles.cxxfiles wrongly used as headers.h.RecoDecay.