[PWGJE] Add missing event selection to processReco in jetShape task by ynishida-style · Pull Request #14280 · AliceO2Group/O2Physics

ynishida-style · 2025-12-18T14:19:11Z

Added missing event and track selections to the recently introduced process.

github-actions · 2025-12-18T14:19:28Z

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

fjonasALICE · 2025-12-18T20:12:08Z

PWGJE/Tasks/jetShape.cxx


    float centrality = collision.centFT0M();
-    float rho = collision.rho();
+    // float rho = collision.rho();


why is rho subtraction removed?

Thank you for the comment. This quantity is obtained for the detector efficiency correction. I had removed it once, assuming it was not necessary, but after reviewing it again, I realized that it is indeed needed, so I restored it. Thank you for pointing this out.

fjonasALICE · 2025-12-18T20:13:18Z

PWGJE/Tasks/jetShape.cxx

-  void processInclusiveProductionRatio(soa::Filtered<soa::Join<aod::Collisions, aod::CentFT0Ms>>::iterator const& collision, soa::Join<aod::Tracks, aod::pidTPCFullPi, aod::pidTOFFullPi, aod::pidTPCFullPr, aod::pidTOFFullPr, aod::TracksExtra, aod::TracksDCA, aod::pidTOFbeta, aod::pidTOFmass> const& tracks)
+  void processInclusiveProductionRatio(soa::Filtered<soa::Join<aod::Collisions, aod::CentFT0Ms, aod::EvSels>>::iterator const& collision, soa::Join<aod::Tracks, aod::pidTPCFullPi, aod::pidTOFFullPi, aod::pidTPCFullPr, aod::pidTOFFullPr, aod::TracksExtra, aod::TracksDCA, aod::pidTOFbeta, aod::pidTOFmass, o2::aod::TrackSelection> const& tracks)
  {
+    if (!collision.sel8())


why is sel8 hardcoded? I assume this should also use ?

if (!jetderiveddatautilities::selectCollision(collision, eventSelectionBits))

With the aod::Collisions table that was being used, it was not possible to implement this in the same way as in the other processes, which is why it was written in that manner.

In the latest commit, I changed the table to aod::JetCollisions and switched to the approach using jetderiveddatautilities~.

fjonasALICE · 2025-12-18T20:14:10Z

PWGJE/Tasks/jetShape.cxx

      registry.fill(HIST("trackEta"), track.eta());
      registry.fill(HIST("trackPhi"), track.phi());

+      if (!track.isGlobalTrack()) {


why is this hardcoded rather than using je track selection like for the other process functions?

With the aod::track table that was being used, it was not possible to implement this in the same way as in the other processes, which is why it was written in that manner.

In the latest commit, I changed the table to aod::JetTrack and updated the implementation to follow the same approach.
(The same applies to the next comment as well.)

fjonasALICE · 2025-12-18T20:14:30Z

PWGJE/Tasks/jetShape.cxx


    for (const auto& track : tracks) {
+
+      if (!track.isGlobalTrack())


should probably not be hard coded

fjonasALICE · 2025-12-18T20:14:38Z

PWGJE/Tasks/jetShape.cxx

    for (const auto& jet : jets) {
      registry.fill(HIST("jetPt"), jet.pt());

-      float mcdPtCorr = jet.pt() - rho * jet.area();


same comment as above

Related to the first comment, I have restored this.

ynishida-style · 2025-12-24T17:30:08Z

@nzardosh
Could you please have a look at this when you have a moment?
Thank you very much.

nzardosh · 2025-12-19T15:52:36Z

PWGJE/Tasks/jetShape.cxx

                 "production ratio around jets", false);

-  void processInclusiveProductionRatio(soa::Filtered<soa::Join<aod::Collisions, aod::CentFT0Ms>>::iterator const& collision, soa::Join<aod::Tracks, aod::pidTPCFullPi, aod::pidTOFFullPi, aod::pidTPCFullPr, aod::pidTOFFullPr, aod::TracksExtra, aod::TracksDCA, aod::pidTOFbeta, aod::pidTOFmass> const& tracks)
+  void processInclusiveProductionRatio(soa::Filtered<aod::JetCollisions>::iterator const& collision, soa::Join<aod::JetTracks, aod::pidTPCFullPi, aod::pidTOFFullPi, aod::pidTPCFullPr, aod::pidTOFFullPr, aod::TracksExtra, aod::TracksDCA, aod::pidTOFbeta, aod::pidTOFmass, o2::aod::TrackSelection> const& tracks)


Hi Yuto. It is not clear why all these table subscriptions are needed? For example why do you need TracksExtra, tracksDCA and TrackSelection?
Also please seperate JetTracks and the pidTables into seperate calls and get the pid from track.tracks_as<>(). For this you will need to join JTrackPIs to JetTracks

Dear Nima,

Thank you for the feedback.

The trackExtra and trackDCA are necessary to access track.dcaXY and track.tpcSignal for applying additional track cuts and QA.

As for the trackSelection table, keeping it was an oversight in the previous change.

I will proceed with separating the jetTracks and pid tables.

nzardosh · 2026-01-02T10:10:57Z

PWGJE/Tasks/jetShape.cxx

  PROCESS_SWITCH(JetShapeTask, processReco, "process reconstructed simulation information", true);

-  void processSim(soa::Join<aod::McCollisions, aod::McCentFT0Ms>::iterator const& mcCollision, aod::ChargedMCParticleLevelJets const& mcpjets, aod::McParticles const& mcParticles)
+  void processSim(soa::Join<aod::McCollisions, aod::McCentFT0Ms>::iterator const& mcCollision,


why are these not using the JE framework?

This appears as a change due to a line break, but I am simply using mcpjet here.

But why not use JetMcCollisions and JetParticles too?

…liceO2Group#14280)

Add missing event selection to processReco

37b7ea9

ynishida-style requested review from alibuild, fjonasALICE, maoyx, mfasDa, mhemmer-cern and nzardosh as code owners December 18, 2025 14:19

github-actions bot added the pwgje label Dec 18, 2025

github-actions bot changed the title ~~Add missing event selection to processReco in jetShape task~~ [PWGJE] Add missing event selection to processReco in jetShape task Dec 18, 2025

ynishida-style closed this Dec 18, 2025

ynishida-style reopened this Dec 18, 2025

ynishida-style closed this Dec 18, 2025

ynishida-style reopened this Dec 18, 2025

fjonasALICE reviewed Dec 18, 2025

View reviewed changes

ynishida-style added 2 commits December 19, 2025 18:06

Improvement of the track selection method

20122cc

Reduce CPU usage in processSim by reordering particle–jet loops

c407842

nzardosh reviewed Jan 2, 2026

View reviewed changes

Update the table selection

83aeef4

nzardosh approved these changes Jan 15, 2026

View reviewed changes

nzardosh enabled auto-merge (squash) January 15, 2026 17:06

nzardosh merged commit 44e31ff into AliceO2Group:master Jan 15, 2026
14 checks passed

FrancescaCasillo pushed a commit to FrancescaCasillo/O2Physics that referenced this pull request Jan 26, 2026

[PWGJE] Add missing event selection to processReco in jetShape task (A…

add2f05

…liceO2Group#14280)

fcolamar pushed a commit to fcolamar/O2Physics that referenced this pull request Feb 4, 2026

[PWGJE] Add missing event selection to processReco in jetShape task (A…

9248393

…liceO2Group#14280)

karlazertova pushed a commit to karlazertova/O2Physics that referenced this pull request Feb 5, 2026

[PWGJE] Add missing event selection to processReco in jetShape task (A…

bb13e35

…liceO2Group#14280)


		for (const auto& track : tracks) {

		if (!track.isGlobalTrack())

Conversation

ynishida-style commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ynishida-style commented Dec 24, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 18, 2025 •

edited

Loading