[PWGUD] use get track size and add flowMC by miedema-11 · Pull Request #15679 · AliceO2Group/O2Physics

miedema-11 · 2026-04-08T06:36:55Z

No description provided.

github-actions · 2026-04-08T06:37:11Z

O2 linter results: ❌ 1 errors, ⚠️ 2 warnings, 🔕 4 disabled

alibuild · 2026-04-08T06:43:30Z

Error while checking build/O2Physics/o2 for 4eeefde at 2026-04-08 08:43:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:385:10: error: variable 'getTracksSize' set but not used [-Werror=unused-but-set-variable]
ninja: build stopped: subcommand failed.

Full log here.

vkucera · 2026-04-08T09:51:43Z

@miedema-11 This is a duplicate of #15626. Please do not do that. I made several suggestions on your previous PR which are now completely disconnected from this version and I have to visually compare both versions to see your implementation of my comments.

vkucera · 2026-04-08T09:53:48Z

PWGUD/Tasks/flowMcUpc.cxx

+  bool trackSelected(TTrack const& track)
+  {
+    // auto momentum = std::array<double, 3>{track.px(), track.py(), track.pz()};
+    double pt = track.pt();


Don't change the type.

Will it be fine if I use auto type here?

vkucera · 2026-04-08T09:55:45Z

PWGUD/Tasks/flowMcUpc.cxx

+        LorentzVectorM pMC(mcParticle.px(), mcParticle.py(), mcParticle.pz(), 0); // double phi = RecoDecay::phi(momentum);        // focus on bulk: e, mu, pi, k, p
+        int pdgCode = std::abs(mcParticle.pdgCode());
+        if (pdgCode == PDG_t::kElectron)
+          pMC.SetM(o2::constants::physics::MassElectron);
+        else if (pdgCode == PDG_t::kMuonMinus)
+          pMC.SetM(o2::constants::physics::MassMuon);
+        else if (pdgCode == PDG_t::kPiPlus)
+          pMC.SetM(o2::constants::physics::MassPionCharged);
+        else if (pdgCode == PDG_t::kKPlus)
+          pMC.SetM(o2::constants::physics::MassKaonCharged);
+        else if (pdgCode == PDG_t::kProton)
+          pMC.SetM(o2::constants::physics::MassProton);
+        else
+          continue;
+
+        double pt = pMC.Pt();
+        double eta = pMC.Eta();


All this is completely useless. Transverse momentum and pseudorapidity do not depend on the mass.

Hi, you suggested to use the mcparticle.eta(), but it seems that it is not included the table. So I used these codes taking reference from other ud task.
has no member named 'eta'; did you mean 'beta'?
191 | double eta = track.eta();
| ^~~

Indeed. I got confused by your subscription to McParticles which is not referring to the table in the central data model. My point about mass still holds though.
For the eta calculation, you can just use a RecoDecay method.
A more general improvement would be to add dynamic columns in the UD tables for the missing variables.

vkucera · 2026-04-08T09:56:41Z

PWGUD/Tasks/flowMcUpc.cxx

+      auto mcParticle = track.udMcParticle();
+      int pdgCode = std::abs(mcParticle.pdgCode());
+      if (pdgCode == PDG_t::kElectron)
+        recoMC.SetM(o2::constants::physics::MassElectron);
+      else if (pdgCode == PDG_t::kMuonMinus)
+        recoMC.SetM(o2::constants::physics::MassMuon);
+      else if (pdgCode == PDG_t::kPiPlus)
+        recoMC.SetM(o2::constants::physics::MassPionCharged);
+      else if (pdgCode == PDG_t::kKPlus)
+        recoMC.SetM(o2::constants::physics::MassKaonCharged);
+      else if (pdgCode == PDG_t::kProton)
+        recoMC.SetM(o2::constants::physics::MassProton);
+      else
+        continue;
+
+      double pt = recoMC.Pt();
+      double eta = recoMC.Eta();


amatyja · 2026-04-08T11:22:32Z

Hi @miedema-11,
Incorporate the corrections suggested by Vit, please.
Best regards
Adam

miedema-11 · 2026-04-09T05:49:46Z

@miedema-11 This is a duplicate of #15626. Please do not do that. I made several suggestions on your previous PR which are now completely disconnected from this version and I have to visually compare both versions to see your implementation of my comments.

Not exactly, I also modify the flowcorrelationupc.cxx, so I open a new one to avoid conflict. And I already corrected the code according to your comment. Maybe I haven't done it correctly?

vkucera · 2026-04-09T06:29:36Z

PWGUD/Tasks/flowMcUpc.cxx

+
+  double epsilon = 1e-6;
+
+  using McParticles = soa::Join<aod::UDMcParticles, aod::UDMcTrackLabels>;


This is very misleading. McParticles is a table in the central data model.

miedema-11 added 4 commits April 2, 2026 17:04

add event consistency flag

d616170

add event consistency flag

913605e

MC analysis for flow

7290de7

use get track size

9c3c820

miedema-11 requested review from alibuild, amatyja and rolavick as code owners April 8, 2026 06:36

github-actions bot added the pwgud label Apr 8, 2026

github-actions bot changed the title ~~use get track size and add flowMC~~ [PWGUD] use get track size and add flowMC Apr 8, 2026

miedema-11 force-pushed the master branch from 4eeefde to d5c9bf9 Compare April 8, 2026 06:46

amatyja previously approved these changes Apr 8, 2026

View reviewed changes

vkucera reviewed Apr 8, 2026

View reviewed changes

vkucera reviewed Apr 9, 2026

View reviewed changes

Merge branch 'master' of github.com:miedema-11/O2Physics

6379d5a

miedema-11 dismissed amatyja’s stale review via 6379d5a April 9, 2026 17:16

miedema-11 force-pushed the master branch from d5c9bf9 to 6379d5a Compare April 9, 2026 17:16

amatyja approved these changes Apr 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PWGUD] use get track size and add flowMC#15679

[PWGUD] use get track size and add flowMC#15679
miedema-11 wants to merge 5 commits intoAliceO2Group:masterfrom
miedema-11:master

miedema-11 commented Apr 8, 2026

Uh oh!

github-actions bot commented Apr 8, 2026 •

edited

Loading

Uh oh!

alibuild commented Apr 8, 2026

Uh oh!

vkucera commented Apr 8, 2026

Uh oh!

vkucera Apr 8, 2026

Uh oh!

miedema-11 Apr 9, 2026

Uh oh!

vkucera Apr 9, 2026

Uh oh!

vkucera Apr 8, 2026

Uh oh!

miedema-11 Apr 9, 2026

Uh oh!

vkucera Apr 9, 2026

Uh oh!

vkucera Apr 8, 2026

Uh oh!

amatyja commented Apr 8, 2026

Uh oh!

miedema-11 commented Apr 9, 2026

Uh oh!

vkucera Apr 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants


		double epsilon = 1e-6;

		using McParticles = soa::Join<aod::UDMcParticles, aod::UDMcTrackLabels>;

Conversation

miedema-11 commented Apr 8, 2026

Uh oh!

github-actions bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Apr 8, 2026

Uh oh!

vkucera commented Apr 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amatyja commented Apr 8, 2026

Uh oh!

miedema-11 commented Apr 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Apr 8, 2026 •

edited

Loading