Conversation
knopers8
reviewed
Feb 24, 2025
| boost::property_tree::read_json(listingAsStringStream, listingAsTree); | ||
| try { | ||
| boost::property_tree::read_json(listingAsStringStream, listingAsTree); | ||
| } catch (const boost::property_tree::json_parser::json_parser_error&) { |
Collaborator
There was a problem hiding this comment.
Could you add an error with support level, indicating that the listing did not have correct JSON format due to possibly malformed or missing reply from QCDB? The same comment for the other catch in the PR.
knopers8
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crash was caused by missing exception handling in CcdbDatabase.cxx when we receive something else than expected json as
boost::property_tree::read_jsonthrows an exception in case it fails.This fix was tested on staging. I also tried to create some unit test that catches this, but I wasn't really succesfull is it is not that easy to make ccdb able to initiate but make unresponsive automatically, which is why it took so long to create PR.