MID:: TaskDigits : Add CRU,EP, GBTRate#2539
Conversation
ValerieRamillien
requested review from
Barthelemy,
justonedev1 and
knopers8
as code owners
knopers8
left a comment
knopers8
left a comment
There was a problem hiding this comment.
Thank you @ValerieRamillien ! Please consider my two minor suggestions.
| } else if (mo->getName().find("BendHitsMap") != std::string::npos) { // Strips Display | ||
| // This matches both [N]BendHitsMap* | ||
| int maxStrip = 20; // 20kHz Max Display | ||
| auto histo = dynamic_cast<TH2F*>(mo->getObject()); |
There was a problem hiding this comment.
please check for nullptr in case the cast was not successful
| histo->SetContour(zcontoursStrip.size(), zcontoursStrip.data()); | ||
| histo->SetStats(0); | ||
| } else if (mo->getName() == "Hits") { | ||
| auto histo = dynamic_cast<TH1F*>(mo->getObject()); |
There was a problem hiding this comment.
Ok thanks for these changes and sorry for my late response.
When is it possible to have it at point2?
There was a problem hiding this comment.
Given that we are starting physics, we will perform upgrades more opportunistically, i.e. when we are given a slot by RC. I do not know what is our next slot.
There was a problem hiding this comment.
Ok thanks again
There was a problem hiding this comment.
@ValerieRamillien are you planning to implement these proposed changes?
There was a problem hiding this comment.
Sorry for the delay. I just did it.
3 participants
No description provided.