Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
rugeli
commented
Feb 27, 2026
Comment on lines
+321
to
+326
| const useDefaultOutputDir = () => { | ||
| const manifest = useCurrentRecipeManifest(); | ||
| const recipe = useCurrentRecipeData(); | ||
| return (recipe && manifest?.defaultOutputDir) || ""; | ||
| }; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
when no job runs, falls back to the initial recipe outputs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
What is the problem this work solves, including
closes #182
Solution
What I/we did to solve this problem
Type of change
Please delete options that are not relevant.
Verify
Peroxisome: doesn't have aoutputs_directoryfield in its document,Download packing resultbutton should be greyed out andShareshould be enabledPeroxisome + ERandEndosomehave valid paths foroutputs_directory, both download and share buttons should be enabledRe-runbutton should become enabled, after clickingRe-run, both download and share buttons should be disabled until the re-run packing job succeedsNote: for the next step, we'll use our scripts and client configs to upload the current example recipes rather than inputing manually