Update workflow and dependencies to use external referenced packages#57
Merged
bruno-f-cruz merged 2 commits intomainfrom Mar 27, 2026
Merged
Update workflow and dependencies to use external referenced packages#57bruno-f-cruz merged 2 commits intomainfrom
bruno-f-cruz merged 2 commits intomainfrom
Conversation
micahwoodard
approved these changes
Mar 27, 2026
Collaborator
micahwoodard
left a comment
There was a problem hiding this comment.
Ah okay nice so we'll no longer have to serialize and deserialize types and won't have to keep up with locally defined types?
Member
Author
Yep! Types can now be referenced from external libs (see distribution) which means the type never changes. We can now finally start building packages on top of the same DSL definition and across languages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR (finally) removes locally defined types in favor of references to external packages. One example is the AindManipulator that now correctly references the external types from the AllenNeuralDynamics.AindManipulator namespace