Skip to content

Update workflow and dependencies to use external referenced packages#57

Merged
bruno-f-cruz merged 2 commits intomainfrom
refactor-use-sgen-references
Mar 27, 2026
Merged

Update workflow and dependencies to use external referenced packages#57
bruno-f-cruz merged 2 commits intomainfrom
refactor-use-sgen-references

Conversation

@bruno-f-cruz
Copy link
Copy Markdown
Member

This PR (finally) removes locally defined types in favor of references to external packages. One example is the AindManipulator that now correctly references the external types from the AllenNeuralDynamics.AindManipulator namespace

Copy link
Copy Markdown
Collaborator

@micahwoodard micahwoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay nice so we'll no longer have to serialize and deserialize types and won't have to keep up with locally defined types?

@bruno-f-cruz
Copy link
Copy Markdown
Member Author

Ah okay nice so we'll no longer have to serialize and deserialize types and won't have to keep up with locally defined types?

Yep! Types can now be referenced from external libs (see distribution) which means the type never changes. We can now finally start building packages on top of the same DSL definition and across languages.

@bruno-f-cruz bruno-f-cruz merged commit fa31562 into main Mar 27, 2026
5 checks passed
@bruno-f-cruz bruno-f-cruz deleted the refactor-use-sgen-references branch March 27, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants