Add crop bounds validation for split XML IPD implementation#169
Merged
seanmcculloch merged 3 commits intofeat/squashed-split-xml-ipdfrom Feb 15, 2026
Merged
Add crop bounds validation for split XML IPD implementation#169seanmcculloch merged 3 commits intofeat/squashed-split-xml-ipdfrom
seanmcculloch merged 3 commits intofeat/squashed-split-xml-ipdfrom
Conversation
Co-authored-by: seanmcculloch <86432671+seanmcculloch@users.noreply.github.com>
Co-authored-by: seanmcculloch <86432671+seanmcculloch@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on XML IPD split implementation
Add crop bounds validation for split XML IPD implementation
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Changes You Made
Adds validation to catch invalid crop bounds before Dask raises IndexError. When crop bounds exceed array dimensions after transpose, the error message was cryptic. Now validates early with clear diagnostics.
Validation checks:
crop_min[i] >= 0(non-negative bounds)crop_max[i] < array_shape[i](within dimensions)crop_min[i] <= crop_max[i](valid range)Error messages now include:
Type of Change
Instructions for Testing
Run
python tests/test_detection/test_image_reader.py- includes 3 new test cases covering each validation scenario.Additional Info
Addresses feedback from PR #167: #167 (comment)
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.