Skip to content

FIP metadata update#1719

Open
alexpiet wants to merge 1 commit intodevelopfrom
fix_fip
Open

FIP metadata update#1719
alexpiet wants to merge 1 commit intodevelopfrom
fix_fip

Conversation

@alexpiet
Copy link
Copy Markdown
Collaborator

Pull Request instructions:

  • Please follow the update protocol
  • Answer the questions below in detail. Your responses will be emailed to experimenters.
  • If the experimenters must do anything new, provide detailed step by step instructions on the wiki
  • If computer maintainers need to manually update anything, provide detailed step by step instructions
  • Use markdown syntax in order for your comments to be rendered reliably in the email: "1." instead of "1)", use four spaces for indents.
  • If you use the keyword "skip email" in the title, it will skip the email updates
  • Merges from "develop" into "production_testing" should use the keyword "production merge" in the title for reliable indexing of updates
  • Merges from "production_testing" into "main" should use the keyword "update main"

Describe changes:

  • Changes name of FIP objective in the metadata from "Objective" to "FIP Objective"

What issues or discussions does this update address?

  • Its unclear what the objective is used for

Describe the expected change in behavior from the perspective of the experimenter

  • none

Describe any manual update steps for task computers

  • none

Was this update tested in 446/447?

  • no

Does this update impact downstream processing by adding new saved files, or changing their format? If so, have you documented changes?

  • It creates an inconsistency in the metadata. @hagikent How is the metadata for the VR foraging structured? Should we fix old metadata, or just correct going forward?

Copy link
Copy Markdown
Collaborator

@micahwoodard micahwoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me! Is any software dependent on this naming convention and would be broken if merged?

@alexpiet
Copy link
Copy Markdown
Collaborator Author

This makes sense to me! Is any software dependent on this naming convention and would be broken if merged?

I don't think so, but thats a good question for @hagikent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants