Skip to content

25.8.16 Backport of #87258 - Fix 'Invalid dict indices bit width: 0' in parquet reader v3 #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkmkme wants to merge 1 commit into
base: releases/25.8.16
Choose a base branch
from
Open

25.8.16 Backport of #87258 - Fix 'Invalid dict indices bit width: 0' in parquet reader v3 #1384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Processors/Formats/Impl/Parquet/Decoding.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ struct BitPackedRLEDecoder : public PageDecoder
requireRemainingBytes(1);
bit_width = size_t(UInt8(*data));
data += 1;
if (bit_width > 8 * sizeof(T) || (bit_width == 0 && limit > 1))
if (bit_width > 8 * sizeof(T))
throw Exception(ErrorCodes::INCORRECT_DATA, "Invalid dict indices bit width: {}", bit_width);
}
else
Expand Down Expand Up @@ -120,7 +120,7 @@ struct BitPackedRLEDecoder : public PageDecoder
{
if (bit_width == 0)
{
/// bit_width == 0 can be used for dictionary indices if the dictionary has only one value.
/// bit_width == 0 means all values are 0.
if constexpr (!skip)
memset(out, 0, num_values * sizeof(T));
return;
Expand Down
Loading