Add OAuth2 login to clickhouse-client (--login / --login=device) #1606
Check failed
There are 6 commits incorrectly signed off, the check did not pass.
Summary
| Sha | Message | Pass or fail reason | |
|---|---|---|---|
| 🟢 | bd0cfb8 | Add OAuth2 login to clickhouse-client via credenti... | Valid sign-off found in remediation commit |
| 🟢 | f8f11a2 | Fix Google JWT exp claim type in TokenProcessorsOp... | Valid sign-off found in remediation commit |
| 🟢 | 2c7c933 | Fix review blockers in OAuth2 login implementation | Valid sign-off found in remediation commit |
| 🟢 | 3d03550 | Robustness fixes, issuer discovery, state CSRF, an... | Valid sign-off found in remediation commit |
| 🟢 | 2584ed9 | Merge --login-device into --login=device | Valid sign-off found in remediation commit |
| 🟢 | 1ce5b15 | Fix --login=device crash and --login=browser routi... | Valid sign-off found in remediation commit |
| 🟢 | 537268d | Fix device flow crash on Google verification_url f... | Valid sign-off found in remediation commit |
| 🟢 | 145f276 | Document --login/--oauth-credentials and add OAuth... | Valid sign-off found in remediation commit |
| 🟢 | 6b9a4a1 | DCO Remediation Commit | Valid sign-off found |
| 🔴 | cd027be | Fix security and reliability issues in OAuth2 logi... | Sign-off not found |
| 🔴 | 8c0bc56 | Fix Google OAuth scope: use access_type=offline in... | Sign-off not found |
| 🔴 | 1c71246 | Split OAuthJWTProvider into its own file; fix sile... | Sign-off not found |
| 🔴 | f577fc3 | Add OAuth2 integration tests and fix remaining rev... | Sign-off not found |
| 🔴 | 6cf7c55 | Fix blockers in Keycloak integration tests | Sign-off not found |
| 🔴 | c78caad | Fix OAuth HTTPS sessions to respect configured SSL... | Sign-off not found |
Errors details
Sign-off not found
No sign-off was found in the commit message. This usually means that the author or committer of this commit failed to include a Signed-off-by line in the commit message. In some cases, this error can also be raised if the sign-off is not in the correct format.
To avoid having pull requests blocked in the future, always include a Signed-off-by: User1 <user1@email.test> line in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).
How to fix missing or invalid sign-offs
Option 1: add remediation commit
Option 2: fix commits without sign-off
Rebase the branch
If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").
Warning
You should only do this if:
- You are the only author of the commits in this branch
- You are absolutely certain nobody else is doing any work based upon this branch
- There are no empty commits in the branch
To add your Signed-off-by line to every commit in this branch:
- Ensure you have a local copy of your branch by checking out the pull request locally via command line.
- In your local branch, run:
git rebase HEAD~15 --signoff - Force push your changes to overwrite the branch:
git push --force-with-lease origin feature/client-IdP