Antalya 26.1: Support for 'time' type in Iceberg, reading only#1613
Antalya 26.1: Support for 'time' type in Iceberg, reading only#1613ianton-ru wants to merge 4 commits intoantalya-26.1from
Conversation
|
in the issue it is mentioned
So my first guess would be it is a backport, but it doesn't look like. Looking at the diff, i see:
which is not present in upstream https://github.com/ClickHouse/ClickHouse/blob/master/src/Processors/Formats/Impl/AvroRowInputFormat.cpp. Why? |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0e1038e83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (type_name == f_time) | ||
| return std::make_shared<DataTypeInt64>(); | ||
| return std::make_shared<DataTypeTime64>(6); |
There was a problem hiding this comment.
Support Time64 in manifest Avro type mapping
After f_time is remapped to DataTypeTime64(6), inserts into Iceberg tables partitioned by a time column can fail in the write path: ChunkPartitioner::getResultTypes() returns Time64, generateManifestFile() passes that into extendSchemaForPartitions(), and getAvroType() still has no TypeIndex::Time64 branch (it only handles TypeIndex::Time), so it throws Unsupported type for iceberg Time64(...). This is a regression from the previous Int64 mapping because writes for time-partitioned tables now error during manifest generation.
Useful? React with 👍 / 👎.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Support for 'time' type in Iceberg, reading only.
Documentation entry for user-facing changes
Solved #1535
This changes time format,.
Was - seconds from midnight:
Now - time with microseconds
CI/CD Options
Exclude tests:
Regression jobs to run: