Skip to content

25.3.8-fips: Make tests in CI a bit more green#1614

Open
mkmkme wants to merge 4 commits intoreleases/25.3.8-fipsfrom
mkmkme/fips/disable-broken-tests
Open

25.3.8-fips: Make tests in CI a bit more green#1614
mkmkme wants to merge 4 commits intoreleases/25.3.8-fipsfrom
mkmkme/fips/disable-broken-tests

Conversation

@mkmkme
Copy link
Copy Markdown
Collaborator

@mkmkme mkmkme commented Apr 2, 2026

Fix a config in one test, disable a couple of tests.

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

...

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

It requires PRQL that is disabled in FIPS.
@mkmkme mkmkme added fips Work related to Altinity FIPS releases fips-25.3 fips-25.3.8.30001 labels Apr 2, 2026
@mkmkme mkmkme changed the title Disable broken tests 25.3.8-fips: Disable broken tests Apr 3, 2026
mkmkme added 3 commits April 3, 2026 10:27
DeltaLake is not supported in FIPS.
We replaced aes_128_gcm_siv with aes_128_gcm, but it was not reflected
in the test configs. Let's fix it.
@mkmkme mkmkme marked this pull request as ready for review April 3, 2026 08:28
@mkmkme mkmkme changed the title 25.3.8-fips: Disable broken tests 25.3.8-fips: Make tests in CI a bit greener Apr 3, 2026
@mkmkme mkmkme changed the title 25.3.8-fips: Make tests in CI a bit greener 25.3.8-fips: Make tests in CI a bit more green Apr 3, 2026
@mkmkme
Copy link
Copy Markdown
Collaborator Author

mkmkme commented Apr 3, 2026

It's quite odd test_disks_app_func/test.py::test_disks_app_func_rm_shared_recursive is failing in the CI semi-consistently. It's passing locally.

@mkmkme
Copy link
Copy Markdown
Collaborator Author

mkmkme commented Apr 3, 2026

03170_ecs_crash is something odd. Never seen it failing before. And these changes didn't touch it at all.

@mkmkme
Copy link
Copy Markdown
Collaborator Author

mkmkme commented Apr 3, 2026

test_dictionaries_all_layouts_separate_sources/test_mongo_uri.py::test_simple_ssl[flat-True] is an interesting failing test. It also fails on non-fips build from branch releases/25.3.8. So it's unrelated.

@mkmkme
Copy link
Copy Markdown
Collaborator Author

mkmkme commented Apr 3, 2026

test_disks_app_other_disk_types/test.py::test_disks_app_plain_rewritable also can't be reproduced locally, but for some reason is reproduced in CI

@mkmkme
Copy link
Copy Markdown
Collaborator Author

mkmkme commented Apr 3, 2026

test_disks_app_other_disk_types/test.py::test_disks_app_plain_rewritable also can't be reproduced locally, but for some reason is reproduced in CI

Okay it does fail on asan due to memory leak. Investigating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fips Work related to Altinity FIPS releases fips-25.3 fips-25.3.8.30001

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants