fix(s3): wrap credentials with NewCredentialsCache#1335
Merged
Slach merged 3 commits intoAltinity:masterfrom Mar 28, 2026
Merged
fix(s3): wrap credentials with NewCredentialsCache#1335Slach merged 3 commits intoAltinity:masterfrom
Slach merged 3 commits intoAltinity:masterfrom
Conversation
…credential resolution
Collaborator
|
thanks for contibution |
Slach
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aws.NewCredentialsCache()to cache resolved credentials and avoid redundant credential resolution on every API callAssumeRoleProviderin IRSA + AssumeRole flowDetails
Without
NewCredentialsCache, each S3 API call may trigger a fresh credential resolution (e.g., hitting IMDS or STS endpoint). This adds latency and can cause throttling under high request volume.Validation
go test ./pkg/storage/ -v— all unit tests passgo build ./...— build succeeds