Skip to content

fix(s3): wrap credentials with NewCredentialsCache#1335

Merged
Slach merged 3 commits intoAltinity:masterfrom
kakao-tars-case:fix/s3-credentials-cache
Mar 28, 2026
Merged

fix(s3): wrap credentials with NewCredentialsCache#1335
Slach merged 3 commits intoAltinity:masterfrom
kakao-tars-case:fix/s3-credentials-cache

Conversation

@kakao-tars-case
Copy link
Copy Markdown
Contributor

Summary

  • Wrap AWS credentials with aws.NewCredentialsCache() to cache resolved credentials and avoid redundant credential resolution on every API call
  • Also cache credentials before passing to STS AssumeRoleProvider in IRSA + AssumeRole flow

Details

Without NewCredentialsCache, each S3 API call may trigger a fresh credential resolution (e.g., hitting IMDS or STS endpoint). This adds latency and can cause throttling under high request volume.

Validation

  • go test ./pkg/storage/ -v — all unit tests pass
  • go build ./... — build succeeds

@Slach
Copy link
Copy Markdown
Collaborator

Slach commented Mar 24, 2026

thanks for contibution

@Slach Slach added this to the 2.7.0 milestone Mar 24, 2026
@Slach Slach self-requested a review March 24, 2026 12:10
@Slach Slach merged commit d4d3145 into Altinity:master Mar 28, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants