Draft
Conversation
…eration and eFormidling.
…ult enum and use result classes instead, for expandability.
…elds from result class and instead return generic failed ProcessChangeResult.
…served key word Next.
…ncellation params DeleteInstanceIfConfigured and InstancesController.CopyInstance were calling old 3-param overloads of DeleteInstance/CreateInstance that lacked authenticationMethod and CancellationToken parameters. This was a merge casualty from the binary-compatibility commit (dd7b184).
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
…tion Resolves conflicts in ProcessEngine (keep SubmitInitialProcessState + add auto-advance Next/ProcessNext pattern with IInstanceLock) and ProcessEngineTest (add InitLock mock setup, remove LockToken from ProcessNextRequest usages). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bjorntore
force-pushed
the
feat/workflow-engine-integration
branch
from
7f4b36e to
8bdd090
Compare
bjorntore
force-pushed
the
feat/workflow-engine-integration
branch
from
8bdd090 to
e75aa9a
Compare
Contributor
Author
|
/publish |
Contributor
Author
|
/publish --skip-integration |
PR release:
|
…gration" This reverts commit 24b6af5.
Use structured logging templates instead of string interpolation to prevent log injection via user-controlled route parameters. Also stop echoing user input in error responses and activity status descriptions.
…ter name mismatches - Use InvalidOperationException instead of Exception in WorkflowEngineClient and ProcessEngine (S112) - Rename interface parameter 'parameters' to 'context' in IWorkflowEngineCommand to match implementations (S927) - Rename 'processStartRequest' to 'request' in ProcessEngine to match IProcessEngine interface (S927)
URLs are constructed from platform configuration settings, not from user-controlled input. These are server-to-server calls to internal platform services.
Temporary workflow for publishing experimental NuGet packages from PRs that cannot run integration tests (e.g. workflow engine not yet in app-localtest). Triggered by /publish-no-integration in PR comments.
Contributor
Author
|
/publish-no-integration |
PR release:
|
Avoids triggering the original /publish workflow since its contains() check would also match /publish-no-integration.
|
Contributor
|
/publish-no-integration |
PR release:
|
Contributor
Author
|
/pack-experimental |
Contributor
Author
huh, trodde command var renamed. 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Verification
Documentation