Conversation
| // check whether file exists at all, because if not, a full download is required | ||
| if (!isfile(pathToLocalFile)) { | ||
| issueStatusMessage("Cannot find file " + pathToLocalFile + ", triggering full download"); | ||
| issueStatusMessage("Cannot find file " + pathToLocalFile); |
There was a problem hiding this comment.
That's more misleading than before. I already explained what the message means. Now it's more than ambiguous...
There was a problem hiding this comment.
It is not "triggering a full download" if further down below there is a file supplied with -i.
There was a problem hiding this comment.
True. But what's the file and why does it look for it at all? This is not an error, not even a warning. However now it looks like a serious problem.
There was a problem hiding this comment.
Remove the message altogether?
There was a problem hiding this comment.
Why not state that this filename has been taken from the .zsync file, but we couldn't find it?
There was a problem hiding this comment.
That also doesn't tell "why" it's looking for that file. Please add some comment with regards to this. Otherwise it's quite good.
There was a problem hiding this comment.
Skipping file (...) suggested by (...).zsync because it is not found locally at (...)
There was a problem hiding this comment.
I guess .zsync file is sufficient. Not sure what the at part is for. The message doesn't tell what it wants to use the file for. It's like an implicit -i, isn't it?
There was a problem hiding this comment.
How about just mentioning the file if it could be found? Something like "Found file ... suggested by .zsync file locally, trying to use data from it"?
|
@probonopd do you intend to ever update your PR? Or can it be closed? |
2 participants
No description provided.