Conversation
feat: add functions for coloring svg files feat: replace sass colors with css colors
jakubnowicki
left a comment
There was a problem hiding this comment.
Hey, this is a nice improvement 👍 It needs a little bit more polishing; please check my comments.
…refactor/simplify-state
vituri
left a comment
There was a problem hiding this comment.
Looks good! Later we will be able to use the new brand.yml file.
I see that all other comments by Jakub Nowicki were solved as well since his last review.
…ger check_error_text()
|
@jakubnowicki I believe we should be good here and @vituri already confirmed all the comments were addressed. I believe (2?) sequential branches have already been merged into this by him as well. So, we should avoid bloating this further and merge it. Additionally, I could not push to the main repository anymore (I assumed I would be able to do it but some permission issue prevented it) so I forked and created a !23 to add his suggestion for |
…-text Fix: Edge case for `check_error_text()`
|
@jakubnowicki Can we please merge this? I think this is pending a re-review from you still after @vituri's comments and review which confirms all the above items are addressed. |
Have you read the Contributing Guidelines?
Closes #14
Note to reviewers: This was changed before
brand.ymlcame into the picture and works quite similarly. Still, since this is underway and has existing PRs in sequence (#17, #20), it would make sense to go forward with this and then, do a cleanup refactor to use brand.yml with minor changes, if necessary. Although, I don't see the need as of yet because the branding is not as widely present in this app, owing to its simplicity. But it can be something we decide in the future.Description
config.ymlbranding + Sass modifications to access itREADME.mdfor the sameonClickin the app list and job listreactabletablesLoom recording with demo
Definition of Done
R CMD check, linter, unit tests, spelling)..Rdfiles withroxygen2::roxygenise())