Skip to content

chore: remove deprecated version field from compose.yml#5495

Open
YuanyuanMa03 wants to merge 1 commit intoAstrBotDevs:masterfrom
YuanyuanMa03:master
Open

chore: remove deprecated version field from compose.yml#5495
YuanyuanMa03 wants to merge 1 commit intoAstrBotDevs:masterfrom
YuanyuanMa03:master

Conversation

@YuanyuanMa03
Copy link

@YuanyuanMa03 YuanyuanMa03 commented Feb 27, 2026

Summary

  • Removed the deprecated version: '3.8' field from compose.yml

Details

The version field is no longer required in Docker Compose v2 and has been officially deprecated. Modern Docker Compose automatically uses the latest compose file format specification, making this field unnecessary.

Test plan

  • Docker Compose still works correctly without the version field
  • docker compose up starts AstrBot successfully

Summary by Sourcery

增强内容:

  • 通过从 compose.yml 中移除已弃用的 version 字段来现代化 Docker Compose 配置。
Original summary in English

Summary by Sourcery

Enhancements:

  • Modernize Docker Compose configuration by dropping the deprecated version field from compose.yml.

The version field is no longer required in Docker Compose v2 and has been deprecated.
@auto-assign auto-assign bot requested review from Soulter and anka-afk February 27, 2026 01:40
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 27, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the Docker Compose configuration by removing the version field from compose.yml. This change reflects the evolution of Docker Compose, as the version field is now deprecated and automatically handled by modern Docker Compose engines, simplifying the configuration without impacting functionality.

Highlights

  • Docker Compose Configuration: Removed the deprecated version field from compose.yml, aligning with modern Docker Compose practices where the field is no longer required.
Changelog
  • compose.yml
    • Removed the deprecated version: '3.8' field.
Activity
  • The author provided a test plan to ensure Docker Compose functionality remains intact after the change.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot
Copy link

dosubot bot commented Feb 27, 2026

Related Documentation

Checked 1 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the deprecated version field from compose.yml. This is a good cleanup, as this field is no longer necessary with modern versions of Docker Compose. I've added one comment suggesting to apply this change consistently to other compose files in the project for better maintainability.

@@ -1,5 +1,3 @@
version: '3.8'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While removing this deprecated version field is correct, I noticed that compose-with-shipyard.yml still contains version: '3.8'. To ensure consistency across the project, please consider removing it from that file as well in this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YuanyuanMa03 can you also delete version field in the compose-with-shipyard.yml? Thanks!

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗨,我已经审阅了你的修改,看起来很棒!


Sourcery 对开源项目是免费的——如果你觉得我们的评审有帮助,欢迎分享 ✨
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈来改进之后的评审。
Original comment in English

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants