Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
strandlie
force-pushed
the
strandlie/fix-transport-mode
branch
from
4e2420b to
927a2df
Compare
strandlie
requested review from
adriansberg,
cbrevik,
jorunnl,
mathiazom,
mikaelbr,
mortennordseth and
rosvik
reidzeibel
approved these changes
Feb 12, 2026
| serviceKey: string, | ||
| required: boolean = false, | ||
| ): string => { | ||
| console.log('Getting service URL for env', getEnv()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So... Planner web has had the issue that transportMode types are confusing, and there also has been a lot of gymnastics like
leg.transportSubmode ? [transportSubmode] : undefined.The problem:
Every single one of the differently coloured shapes in this image represents a distinct implementation of TransportMode in planner-web from before, and how they did (or did not) overlap
The fix:
This is the new simplified model that this PR introduces
We don't get away from having more than one type, since what is used in the query (graphql) and filters (config-specs) are different, but I think this is a lot better.
Also, we (with one tiny exception, that I found another solution for) never used more than one
transportSubModeat a time, so always having that as an array made no sense.