-
-
Notifications
You must be signed in to change notification settings - Fork 10
feat: Introduce claude code and setting files (#3143) #3144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds Claude Code integration and developer guidance: new centralized docs ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 8
🤖 Fix all issues with AI agents
In @.claude/rules/auth.md:
- Around line 3-6: Update the glob that currently reads "src/lib/server/auth/**"
to the specific file path "src/lib/server/auth.ts" so it matches the actual file
(replace the glob string in the rules block where "globs:" contains
"src/lib/server/auth/**"); ensure the updated entry exactly reads
"src/lib/server/auth.ts" and remove or replace the erroneous directory-style
glob.
In @.claude/rules/testing.md:
- Around line 14-18: Update the Unit test "Location" entry in the test table:
change the pattern shown for Unit tests from `src/**/*.test.ts` to
`src/test/**/*.test.ts` so it matches the layout described on Line 22 and
AGENTS.md and consistently reflects that unit tests live under the `src/test/`
directory.
- Around line 46-49: AGENTS.md is missing the documented "pnpm coverage" command
referenced in .claude/rules/testing.md; add an entry for "pnpm coverage" to the
Commands section of AGENTS.md that explains it runs the test coverage reporter
(and mention the project targets: 80% lines, 70% branches as specified in
.claude/rules/testing.md) so users can discover and run the command; include the
exact command string "pnpm coverage" and a brief one-line description in the
Commands list to match the testing rules.
In @.devcontainer/devcontainer.json:
- Around line 9-12: The devcontainer mounts assume host ~/.claude exists which
can lead Docker to auto-create a root-owned directory; update
.devcontainer/devcontainer.json to either add a postCreateCommand that checks
for and creates ~/.claude on the host with correct ownership or add
documentation/instructions to run `claude login` on the host before opening the
container; reference the "mounts" array and add a "postCreateCommand" entry (or
README note) that creates the host ~/.claude (or instructs the user to run
claude login) to prevent root-owned auto-created directories and permission
issues inside the container.
- Line 25: The devcontainer's postCreateCommand currently only installs the
global Claude Code CLI (the "postCreateCommand" entry with "npm install -g
`@anthropic-ai/claude-code`") but does not install project dependencies tracked by
pnpm (pnpm-lock.yaml); update the postCreateCommand to run pnpm install as part
of the command chain (e.g., run pnpm install then the npm global install, or run
them joined with &&) so the container automatically installs project
dependencies and the global CLI on creation.
In `@AGENTS.md`:
- Line 12: Update the devcontainer port forwarding so the development server
port matches the README: open .devcontainer/devcontainer.json and modify the
forwardPorts array (the forwardPorts setting) to include port 5174 instead of
(or in addition to) 5173 so the container forwards localhost:5174 used by the
dev server described in AGENTS.md.
In `@docs/dev-notes/2026-02-08/simplify-claude-md/plan.md`:
- Around line 101-104: The fenced code block containing the authentication flow
diagram in plan.md lacks a language identifier; update the block that starts
with ``` and includes the flow "A[ユーザー登録] → B[AtCoder認証コード生成] →
C[AtCoder側でコード確認] → D[認証ステータス更新] → E[セッション作成] → F[ログイン完了]" to use a language
identifier (e.g., change ``` to ```text) so the fenced block is properly marked
and remains closed with a matching ``` fence.
- Around line 21-31: Update the fenced code block in plan.md that lists the
repository layout (the block starting with "AGENTS.md #
メイン(約50行)- Codex/Claude 共通" and ending with ".github/instructions/ #
削除(Copilot専用、情報が古い)") to include a language identifier (e.g., change ``` to
```text) so the diagram is rendered correctly and tooling/static analysis no
longer flags the block.
🧹 Nitpick comments (2)
.devcontainer/devcontainer.json (1)
93-95:NODE_OPTIONSapplies globally to all Node.js processes.
--max-old-space-size=4096and--dns-result-order=ipv4firstwill affect every Node process in the container (dev server, build, tests, Prisma CLI, etc.), not just Claude Code. The plan document acknowledges this trade-off. Just flagging for awareness — if any Node tooling misbehaves, this is a likely culprit.CLAUDE.md (1)
1-1: Nit: heading repeats the filename.Consider a more descriptive heading like
# Claude Code Guidelinesinstead of# CLAUDE.md.
postCreateCommand to run pnpm install (#3143)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/dev-notes/2026-02-08/simplify-claude-md/plan.md`:
- Line 175: The line containing the truncated fragment "コードが正" in the document
(the sentence that begins "4. **認証フロー図は実態と異なっていた**:
ドキュメントの図と実装が乖離していたため、移管せず削除。コードが正") should be completed to a full sentence—e.g.,
"コードが正しいため移管の必要がなかった" or another intended ending—so update that sentence in
plan.md to a grammatically complete statement, preserve the Japanese
wording/context, and run a quick spell/encoding check to ensure no other
truncation remains.
KATO-Hiro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#3143
Summary by CodeRabbit
Documentation
Chores