Skip to content

Fix Xcode 26 compatibility: replace NULL with nullptr in SampleOscillator#29

Merged
wtholliday merged 1 commit intoAudioKit:mainfrom
jabou:fix/xcode26-nullptr-sampleoscillator
Mar 26, 2026
Merged

Fix Xcode 26 compatibility: replace NULL with nullptr in SampleOscillator#29
wtholliday merged 1 commit intoAudioKit:mainfrom
jabou:fix/xcode26-nullptr-sampleoscillator

Conversation

@jabou
Copy link
Copy Markdown
Contributor

@jabou jabou commented Mar 26, 2026

Summary

  • Replace NULL with C++ nullptr in SampleOscillator.h
  • Xcode 26.4 stricter headers no longer implicitly provide NULL via <math.h>

Test plan

  • swift build compiles successfully

…ator.h

NULL is not guaranteed in stricter Xcode 26 headers. Use C++ nullptr keyword instead.
@jabou jabou requested review from aure and wtholliday as code owners March 26, 2026 12:57
@NickCulbertson
Copy link
Copy Markdown
Member

Thanks! This looks good to me! NULL is still working for me in Xcode 26, but we use nullptr in other places so seems like a good fix.

@jabou
Copy link
Copy Markdown
Contributor Author

jabou commented Mar 26, 2026

Hey @NickCulbertson

This affects Xcode 26.4., There were many C++ changes made by Apple in that version, so there's an issue.
My bad, the description was a bit misleading, I'll update it now.

@NickCulbertson
Copy link
Copy Markdown
Member

@aure This PR works for me.

@getdunne
Copy link
Copy Markdown
Member

You fellows will have to approve this. I dont' think I'm authorized anymore.

@wtholliday wtholliday merged commit 3a73eaa into AudioKit:main Mar 26, 2026
1 of 2 checks passed
@jabou
Copy link
Copy Markdown
Contributor Author

jabou commented Mar 27, 2026

Hi @aure ,

Would it be possible to create a new version that includes this fix so we can update the project link to the officially released version?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants