Fix Xcode 26 compatibility: replace NULL with nullptr in SampleOscillator#29
Merged
wtholliday merged 1 commit intoAudioKit:mainfrom Mar 26, 2026
Merged
Conversation
…ator.h NULL is not guaranteed in stricter Xcode 26 headers. Use C++ nullptr keyword instead.
Member
|
Thanks! This looks good to me! |
Contributor
Author
|
Hey @NickCulbertson This affects Xcode 26.4., There were many C++ changes made by Apple in that version, so there's an issue. |
Member
|
@aure This PR works for me. |
Member
|
You fellows will have to approve this. I dont' think I'm authorized anymore. |
wtholliday
approved these changes
Mar 26, 2026
Contributor
Author
|
Hi @aure , Would it be possible to create a new version that includes this fix so we can update the project link to the officially released version? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NULLwith C++nullptrinSampleOscillator.hNULLvia<math.h>Test plan
swift buildcompiles successfully