fix(mobile): sync profile status bar with scroll#14117
Draft
dylanjeffers wants to merge 1 commit intomainfrom
Draft
fix(mobile): sync profile status bar with scroll#14117dylanjeffers wants to merge 1 commit intomainfrom
dylanjeffers wants to merge 1 commit intomainfrom
Conversation
Use the same scroll threshold as ProfileNavOverlay so system bar content switches to dark on light blur and back to light at the top. Co-authored-by: Dylan Jeffers <dylanjeffers@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the mobile profile screen, nav icons transition from white to the default theme color as the user scrolls past the cover photo. The status bar stayed on
light-contentbecauseProfileScreencalleduseStatusBarStyle('light-content'), so clock/battery did not gain contrast on the light blurred header.This change removes that static hook for the loaded profile state and drives status bar (and Android navigation bar) style from the same scroll shared value and threshold as
ProfileNavOverlay(PROFILE_NAV_SCROLL_FADE_PX, 60px). At the top, system bar content is light again; after scrolling past the threshold it switches to dark content.Implementation
PROFILE_NAV_SCROLL_FADE_PXfromProfileNavOverlay(replacing the file-local constant).useProfileScrollStatusBar, which pushesreact-native-barsstack entries on focus, usesreplaceStackEntrywhen scroll crosses the threshold, and syncs once on focus viarequestAnimationFramefor restored scroll positions.Testing
Not run in this environment (
tsc/ workspace deps unavailable). Please verify on device/simulator: scroll profile past header, confirm status bar icons darken; scroll back to top, confirm they return to white.