Add exception to Admin view for Multisite installations#3831
Open
dariusk wants to merge 1 commit intoAutomattic:trunkfrom
Open
Add exception to Admin view for Multisite installations#3831dariusk wants to merge 1 commit intoAutomattic:trunkfrom
dariusk wants to merge 1 commit intoAutomattic:trunkfrom
Conversation
On a Multisite Network installation, local Admins (as opposed to "Network" AKA "Super" Admins) [have reduced capabilities compared to the Admin role on standard installations](https://developer.wordpress.org/advanced-administration/multisite/administration/#user-access-capabilities). Specifically they can't install new plugins. This commit skips over some `add_filter` calls that were causing errors on the plugin listing page when an Admin without the elevated multisite privileges would view the plugin listings. This will still work correctly for a super-Admin with the plugin installation privileges since the `is_network_admin()` will catch that and render the correct available actions.
adekbadek
reviewed
Mar 14, 2025
| public function __construct() { | ||
| add_filter( 'all_plugins', [ $this, 'inject_managed_plugins' ] ); | ||
| add_filter( 'plugin_action_links', [ $this, 'modify_action_links' ], 10, 3 ); | ||
| if ( ! is_multisite() || is_network_admin() ) { |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
On a Multisite Network installation, local Admins (as opposed to "Network" AKA "Super" Admins) have reduced capabilities compared to the Admin role on standard installations. Specifically they can't install new plugins.
For Multisite users viewing the Admin page but who do not have Network Admin privileges, this commit skips over some
add_filtercalls that were causing errors on the plugin listing page (since the Admin did not actually have those capabilities).This will still work correctly for a Network Admin with the plugin installation privileges since the
is_network_admin()will catch that and render the correct available actions.(co-authored by @jsdiaz)
How to test the changes in this Pull Request:
Other information: