added non-flake nix compatibility with flake-compat#2009
Open
sunworms wants to merge 1 commit intoAvengeMedia:masterfrom
Open
added non-flake nix compatibility with flake-compat#2009sunworms wants to merge 1 commit intoAvengeMedia:masterfrom
sunworms wants to merge 1 commit intoAvengeMedia:masterfrom
Conversation
LuckShiba
reviewed
Mar 16, 2026
Collaborator
LuckShiba
left a comment
LuckShiba
left a comment
There was a problem hiding this comment.
The addition looks okay, but I'm thinking about how necessary that is. Users that doesn't want to use the flake should in a best-case scenario use the Nixpkgs module, but it's still not in stable so I guess that is okay.
The only problem here is that it'll add two new top-level Nix files, which is okay but not ideal. @sunworms, I don't know much about non-flake usage, would it be viable having these files inside distro/nix or not at all?
Collaborator
|
By testing here it seems to work by moving the files to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add compatibility for non-flake setups by adding the input
NixOS/flake-compatand creating adefault.nixand ashell.nixthat provide the same outputs as the ones provided by the flake.