Conversation
Ayrx
left a comment
Ayrx
left a comment
There was a problem hiding this comment.
Thanks for the PR! I've left some quick comments.
tests/test.xml
Outdated
| <debugging level="0"/> | ||
| <host starttime="1588318812" endtime="1588318814"><status state="up" reason="echo-reply" reason_ttl="53"/> | ||
| <address addr="45.33.32.156" addrtype="ipv4"/> | ||
| <address addr="45.33.32.156" addrtype="ipv4" vendor="VMware"/> |
There was a problem hiding this comment.
This is very clearly wrong as addrtype="ipv4". tests/issue_1.xml has a valid example of a addrtype="mac".
src/host.rs
Outdated
|
|
||
| let vendor = node | ||
| .attribute("vendor") | ||
| .unwrap_or_default(); |
There was a problem hiding this comment.
I don't like this approach. If the vendor field is always present, we should just use .expect() here with the expectation that it should never fail. If the vendor field is option, it should be an Option<String>.
There was a problem hiding this comment.
The problem is that the vendor field isnt always present on nmap output..
Check this..
And for this i set the vendor field to an empty string if the field is not found..
what do you think about it?
Ric
There was a problem hiding this comment.
In that case, Option<String> is the perfect type for that.
There was a problem hiding this comment.
In that case,
Option<String>is the perfect type for that.
Ok thanks, i'll try to fix it.. :)
|
Thanks for reply!!!!! :) |
2 participants
Hi, I needed to read the network card vendor of the devices contacted, I saw that you didn't add it in your code, I did it.. it's my first PR, let me know..
Thank you!!
Riccardo