feat: remove epk sign from message payload#20926
Merged
nventuro merged 2 commits intomerge-train/fairiesfrom Feb 27, 2026
Merged
feat: remove epk sign from message payload#20926nventuro merged 2 commits intomerge-train/fairiesfrom
nventuro merged 2 commits intomerge-train/fairiesfrom
Conversation
nventuro
changed the title
nventuro
commented
Feb 26, 2026
| /// | ||
| /// This is useful as it means it is possible to just broadcast the x-coordinate as a single `Field` and then | ||
| /// reconstruct the original public key using [`crate::utils::point::point_from_x_coord_and_sign`] with `sign: true`. | ||
| pub fn generate_positive_ephemeral_key_pair() -> (Scalar, Point) { |
Contributor
Author
There was a problem hiding this comment.
I added a new fn to avoid changing the other one, since we want to backport this and minimize breakage. There's a linear task to clean this up later on.
Contributor
There was a problem hiding this comment.
Can we add a TODO with the linear task id?
Contributor
Author
There was a problem hiding this comment.
It's done already 🙃
nchamo
approved these changes
Feb 26, 2026
| /// | ||
| /// This is useful as it means it is possible to just broadcast the x-coordinate as a single `Field` and then | ||
| /// reconstruct the original public key using [`crate::utils::point::point_from_x_coord_and_sign`] with `sign: true`. | ||
| pub fn generate_positive_ephemeral_key_pair() -> (Scalar, Point) { |
Contributor
There was a problem hiding this comment.
Can we add a TODO with the linear task id?
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
…om-message-ciphertext
nventuro
deleted the
nico/f-368-remove-epk_sign-from-message-ciphertext
branch
Collaborator
|
❌ Failed to cherry-pick to |
AztecBot
added a commit
that referenced
this pull request
Feb 27, 2026
This frees up one byte of capacity, but more importantly it reduces the leakage in the logs as they'll no longer contain a byte that is either 0 or 1. Backport of #20926
AztecBot
pushed a commit
that referenced
this pull request
Feb 27, 2026
This frees up one byte of capacity, but more importantly it reduces the leakage in the logs as they'll no longer contain a byte that is either 0 or 1.
AztecBot
added a commit
that referenced
this pull request
Feb 27, 2026
This frees up one byte of capacity, but more importantly it reduces the leakage in the logs as they'll no longer contain a byte that is either 0 or 1. Cherry-pick of 2ba3311 with conflict resolution for v4. Conflicts in encoding.nr and aes128.nr due to different MESSAGE_CIPHERTEXT_LEN (17 on v4 vs 15 on next) and absence of AES128_PKCS7_EXPANSION_IN_BYTES on v4.
AztecBot
added a commit
that referenced
this pull request
Feb 27, 2026
Adds the detailed docstring for the AES128 encrypt method that was part of the original PR on next, adapted for v4's constants.
AztecBot
added a commit
that referenced
this pull request
Feb 27, 2026
Raw cherry-pick of 2ba3311 onto v4 with unresolved conflict markers in encoding.nr and aes128.nr.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
BEGIN_COMMIT_OVERRIDE feat: remove epk sign from message payload (#20926) END_COMMIT_OVERRIDE
AztecBot
pushed a commit
that referenced
this pull request
Feb 27, 2026
This frees up one byte of capacity, but more importantly it reduces the leakage in the logs as they'll no longer contain a byte that is either 0 or 1.
Collaborator
|
✅ Successfully backported to backport-to-v4-staging #20980. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This frees up one byte of capacity, but more importantly it reduces the leakage in the logs as they'll no longer contain a byte that is either 0 or 1.