feat(avm)!: Unify nullifier, written slots and retrieved bytecodes tree traces#20949
Open
sirasistant wants to merge 5 commits intoarv/pre_audit_nullifier_tree_checkfrom
Open
feat(avm)!: Unify nullifier, written slots and retrieved bytecodes tree traces#20949sirasistant wants to merge 5 commits intoarv/pre_audit_nullifier_tree_checkfrom
sirasistant wants to merge 5 commits intoarv/pre_audit_nullifier_tree_checkfrom
Conversation
sirasistant
requested review from
IlyasRidhuan,
Maddiaa0,
fcarreiro and
jeanmon
as code owners
sirasistant
removed request for
IlyasRidhuan,
Maddiaa0,
fcarreiro and
jeanmon
sirasistant
commented
Feb 27, 2026
| @@ -0,0 +1,282 @@ | |||
| include "merkle_check.pil"; | |||
Contributor
Author
There was a problem hiding this comment.
It's the old nullifier check, renamed, with renaming of nullifier => value, leaf_not_exists renamed to not_exists, parametrized tree height and siloing separator, and exposing tree_size_after_write.
sirasistant
commented
Feb 27, 2026
| @@ -0,0 +1,398 @@ | |||
| #include <gmock/gmock.h> | |||
Contributor
Author
There was a problem hiding this comment.
It's the old nullifier tree check test
sirasistant
commented
Feb 27, 2026
| @@ -0,0 +1,233 @@ | |||
| #include "barretenberg/vm2/simulation/gadgets/indexed_tree_check.hpp" | |||
Contributor
Author
There was a problem hiding this comment.
It's the nullifier tree check renamed and with updated comments and minor changes. Diff it manually.
sirasistant
commented
Feb 27, 2026
| @@ -0,0 +1,404 @@ | |||
| #include "barretenberg/vm2/simulation/gadgets/indexed_tree_check.hpp" | |||
Contributor
Author
There was a problem hiding this comment.
Also the old nullifier gadget test renamed :/
sirasistant
commented
Feb 27, 2026
| #include "barretenberg/vm2/tracegen/lib/discard_reconstruction.hpp" | ||
|
|
||
| namespace bb::avm2::tracegen { | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Also the nullifier one renamed with minor changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nullifier tree check was a superset of written slots and retrieved bytecodes tree check. Unify all three into the nullifier tree check implementation generalized as "indexed tree check"