Skip to content

fix: avoid inserting unused witnesses into circuit #20965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TomAFrench wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix: avoid inserting unused witnesses into circuit #20965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .../crates/private-kernel-lib/src/accumulated_data/assert_sorted_padded_transformed_array.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,13 @@ where
unconstrained fn get_num_padded_items<Value, let N: u32>(
padded_items: [Value; N],
original_array_length: u32,
CappedSize: u32,
capped_size: u32,
) -> u32
where
Value: Ordered,
{
let mut num_padded_items = 0;
for i in original_array_length..CappedSize {
for i in original_array_length..capped_size {
if padded_items[i].counter() == MAX_U32_VALUE {
// Only padding items have this counter.
num_padded_items += 1;
Expand All @@ -109,7 +109,7 @@ where
{
// Safety: The hints are constrained by `assert_sorted_padded_transformed_i_array_capped_size_with_hints`.
let (sorted_index_hints, num_padded_items_hint) = unsafe {
let sorted_indexes = get_order_hints(original_array.array).sorted_indexes;
let sorted_indexes = get_sorted_indexes(original_array.array);
let num_padded_items =
get_num_padded_items(padded_items, original_array.length, CappedSize);
(sorted_indexes, num_padded_items)
Expand All @@ -125,6 +125,13 @@ where
)
}

unconstrained fn get_sorted_indexes<T, let N: u32>(original_array: [T; N]) -> [u32; N]
where
T: Ordered + Empty,
{
get_order_hints(original_array).sorted_indexes
}

/// @param original_array - is technically the so-called `kept_` array that's already been through squashing; it's "original" from
/// the perspective of this function and the transformations it will apply.
/// @param CappedSize - is a comptime constant for the number of siloing iterations this variant of the circuit supports.
Expand Down