feat(sequencer): (A-526) rotate publishers when send fails (backport #20888)#20968
Draft
feat(sequencer): (A-526) rotate publishers when send fails (backport #20888)#20968
Conversation
When Multicall3.forward() throws a send-level error, retry with the next available publisher instead of returning undefined. On-chain reverts and simulation errors are not retried. Co-authored-by: danielntmd <danielntmd@nethermind.io>
The cherry-pick from next had conflicts because v4 lacks the txContext (failed tx backup) feature. This commit: - Replaces direct Multicall3.forward call with forwardWithPublisherRotation - Calls callbackBundledTransactions without txContext param (not on v4)
AztecBot
force-pushed
the
claudebox/cfac9bcd6262b67d-1
branch
from
d56a84b to
7275789
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #20888 to v4.
When Multicall3.forward() throws a send-level error, retry with the next available publisher instead of returning undefined. On-chain reverts and simulation errors are not retried.
Conflict resolution
The cherry-pick had a conflict in
sequencer-publisher.tsbecause v4 doesn't have thetxContext(failed tx backup) feature that exists onnext. The resolution:forwardWithPublisherRotationmethod and its integrationcallbackBundledTransactionswithout thetxContextparameter (not available on v4)txContextcontext-capturing block that was part of the incoming changes but depends onnext-only codeClaudeBox log