Open
Conversation
iAmMichaelConnor
requested review from
IlyasRidhuan,
LeilaWang,
Maddiaa0,
fcarreiro and
jeanmon
as code owners
|
|
||
| pol commit salted_init_hash; | ||
|
|
||
| // It's reused between the partial address and salted initialization hash. Weird. |
Contributor
Author
There was a problem hiding this comment.
WEIRD, RIGHT?!
Contributor
Author
|
@LeilaWang please could you review the nr changes? @IlyasRidhuan (or someone else on the avm team) please could you review the PIL & cpp changes, because I'm unfamiliar with that code. |
LeilaWang
approved these changes
Feb 27, 2026
| const saltedInitializationHash = await poseidon2HashWithSeparator( | ||
| [salt, initializationHash, deployer], | ||
| DomainSeparator.PARTIAL_ADDRESS, | ||
| DomainSeparator.SALTED_INITIALIZATION_HASH, |
Contributor
There was a problem hiding this comment.
Maybe reuse the util from contract_address.ts here?
await computeSaltedInitializationHash({ salt, initializationHash, deployer })
AztecBot
force-pushed
the
mc/fix-wrong-domain-separator
branch
from
4aa21ca to
d92e699
Compare
When writing an address spec I noticed the same domain separator is being used in two places when deriving an address. This PR introduces DOM_SEP__SALTED_INITIALIZATION_HASH to replace the incorrect usage of DOM_SEP__PARTIAL_ADDRESS.
AztecBot
force-pushed
the
mc/fix-wrong-domain-separator
branch
from
d92e699 to
96ee4c8
Compare
iAmMichaelConnor
removed this pull request from the merge queue due to a manual request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing an address spec I noticed the same domain separator is being used in two places when deriving an address.
This PR introduces DOM_SEP__SALTED_INITIALIZATION_HASH to replace the incorrect usage of DOM_SEP__PARTIAL_ADDRESS.