fix: add retry in assertMultipleBlocksPerSlot to wait for checkpoint indexing#20977
Open
AztecBot wants to merge 1 commit intomerge-train/spartanfrom
Open
fix: add retry in assertMultipleBlocksPerSlot to wait for checkpoint indexing#20977AztecBot wants to merge 1 commit intomerge-train/spartanfrom
AztecBot wants to merge 1 commit intomerge-train/spartanfrom
Conversation
…indexing The test was failing because assertMultipleBlocksPerSlot queries the archiver for checkpoints immediately after all transactions are mined. In CI, there's a race between the archiver indexing checkpoint 3 (which has 3 blocks) and the test assertion. Checkpoint 3 was being downloaded at the same millisecond as the assertion ran, resulting in only 2 checkpoints being found (with max 2 blocks each). This fix adds a retryUntil poll that waits up to 3 L2 slot durations for a checkpoint with the expected block count to appear before performing the full assertion.
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
epochs_mbps.parallel.test.tswhereassertMultipleBlocksPerSlotqueries the archiver for checkpoints immediately after all txs are mined, but the archiver hasn't finished indexing the latest checkpoint yetexpect(multiBlockCheckpointNumber).toBeDefined()to failretryUntilpoll (up to 3 L2 slot durations) that waits for a checkpoint with the expected block count to appear before performing the full block ordering assertionsClaudeBox log