fix: set wallet minFeePadding in BotFactory constructor#20992
Merged
alexghr merged 1 commit intomerge-train/spartanfrom Mar 2, 2026
Merged
fix: set wallet minFeePadding in BotFactory constructor#20992alexghr merged 1 commit intomerge-train/spartanfrom
alexghr merged 1 commit intomerge-train/spartanfrom
Conversation
alexghr
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wallet.setMinFeePadding(config.minFeePadding)in theBotFactoryconstructor so that all transactions during bot setup (token deployment, minting) use the configured fee padding instead of the wallet's default (0.5).config.minFeePadding(line 226 of factory.ts), while token deploy and minting relied on the wallet default, causing insufficient fee headroom when gas prices escalate during rapid block building in tests.Root cause
The merge-train/spartan PR (#20899) was dequeued because
e2e_bot.test.ts("does not reuse prior bridge claims if recipient address changes") failed with:The test config had
minFeePadding: 99(100x multiplier), but this was only applied during account deployment, not during subsequent token deployment/minting which used the wallet's default 1.5x multiplier.Test plan
make yarn-projectbuilds successfullyClaudeBox log