Skip to content

fix: set wallet minFeePadding in BotFactory constructor#20992

Merged
alexghr merged 1 commit intomerge-train/spartanfrom
claudebox/e9fdbc1ddac8e593-1
Mar 2, 2026
Merged

fix: set wallet minFeePadding in BotFactory constructor#20992
alexghr merged 1 commit intomerge-train/spartanfrom
claudebox/e9fdbc1ddac8e593-1

Conversation

@AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented Mar 2, 2026

Summary

  • Sets wallet.setMinFeePadding(config.minFeePadding) in the BotFactory constructor so that all transactions during bot setup (token deployment, minting) use the configured fee padding instead of the wallet's default (0.5).
  • Previously, only account deployment explicitly used config.minFeePadding (line 226 of factory.ts), while token deploy and minting relied on the wallet default, causing insufficient fee headroom when gas prices escalate during rapid block building in tests.

Root cause

The merge-train/spartan PR (#20899) was dequeued because e2e_bot.test.ts ("does not reuse prior bridge claims if recipient address changes") failed with:

maxFeesPerGas.feePerL2Gas must be greater than or equal to gasFees.feePerL2Gas,
but got maxFeesPerGas.feePerL2Gas=698400000 and gasFees.feePerL2Gas=932700000

The test config had minFeePadding: 99 (100x multiplier), but this was only applied during account deployment, not during subsequent token deployment/minting which used the wallet's default 1.5x multiplier.

Test plan

  • make yarn-project builds successfully
  • CI e2e_bot test passes with the fix

ClaudeBox log

@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label Mar 2, 2026
@alexghr alexghr marked this pull request as ready for review March 2, 2026 10:51
@alexghr alexghr enabled auto-merge (squash) March 2, 2026 10:51
@alexghr alexghr merged commit 38fbbb1 into merge-train/spartan Mar 2, 2026
22 of 25 checks passed
@alexghr alexghr deleted the claudebox/e9fdbc1ddac8e593-1 branch March 2, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants