Skip to content

Fix EF double-write in InterviewSessionRepository #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KhawarHabibKhan wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −9
Open

Fix EF double-write in InterviewSessionRepository #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/InterviewCoach.Mcp.InterviewData/InterviewSessionRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
using System.Text;

using Microsoft.EntityFrameworkCore;

namespace InterviewCoach.Mcp.InterviewData;
Expand Down Expand Up @@ -53,11 +51,13 @@ public async Task<IEnumerable<InterviewSession>> GetAllInterviewSessionsAsync()
record.ProceedWithoutJobDescription = interviewSession.ProceedWithoutJobDescription;
record.UpdatedAt = DateTimeOffset.UtcNow;

var sb = new StringBuilder();
sb.AppendLine(record.Transcript ?? string.Empty);
sb.AppendLine();
sb.AppendLine(interviewSession.Transcript ?? string.Empty);
record.Transcript = sb.ToString();
var existingTranscript = record.Transcript?.Trim();
var newTranscript = interviewSession.Transcript?.Trim();
record.Transcript = string.IsNullOrEmpty(existingTranscript)
? newTranscript ?? string.Empty
: string.IsNullOrEmpty(newTranscript)
? existingTranscript
: $"{existingTranscript}\n\n{newTranscript}";

await db.InterviewSessions.Where(r => r.Id == interviewSession.Id)
.ExecuteUpdateAsync(r => r.SetProperty(p => p.ResumeLink, record.ResumeLink)
Expand All @@ -69,7 +69,7 @@ await db.InterviewSessions.Where(r => r.Id == interviewSession.Id)
.SetProperty(p => p.Transcript, record.Transcript)
.SetProperty(p => p.UpdatedAt, record.UpdatedAt));

await db.SaveChangesAsync();
db.Entry(record).State = EntityState.Detached;

return record;
}
Expand All @@ -87,7 +87,7 @@ await db.InterviewSessions.Where(r => r.Id == interviewSession.Id)
await db.InterviewSessions.Where(p => p.Id == id)
.ExecuteUpdateAsync(p => p.SetProperty(x => x.IsCompleted, true));

await db.SaveChangesAsync();
db.Entry(record).State = EntityState.Detached;

return record;
}
Expand Down