Refactor HTTP requests to use centralized Invoke-HttpRequestWithRetry#529
Merged
jaredfholgate merged 3 commits intomainfrom Mar 25, 2026
Merged
Refactor HTTP requests to use centralized Invoke-HttpRequestWithRetry#529jaredfholgate merged 3 commits intomainfrom
jaredfholgate merged 3 commits intomainfrom
Conversation
- Add new Invoke-HttpRequestWithRetry cmdlet with built-in retry logic for transient HTTP errors (408, 429, 500, 502, 503, 504) - Refactor Invoke-GitHubApiRequest to delegate retry logic to the new shared cmdlet - Update Test-NetworkConnectivity to use Invoke-HttpRequestWithRetry instead of Invoke-WebRequest - Update Get-TerraformTool to use Invoke-HttpRequestWithRetry for HashiCorp API calls and downloads - Update unit tests to mock the new cmdlet
github-project-automation
bot
moved this to To triage
in Azure Landing Zone Issues & PRs Triage
- Rename github_max_retry_count to http_request_max_retry_count in Deploy-Accelerator (old name kept as alias) - Add http_request_retry_interval_seconds and http_request_timeout_seconds params to Deploy-Accelerator - Thread all three params through New-ModuleSetup, New-FolderStructure, Get-GithubRelease, Get-GithubReleaseTag, Get-HCLParserTool, Get-TerraformTool, Invoke-GitHubApiRequest - Add Write-ToConsoleLog progress messages to all Test- check cmdlets
- Add HttpRequestMaxRetryCount, HttpRequestRetryIntervalSeconds, HttpRequestTimeoutSeconds params to Test-NetworkConnectivity and Test-Tooling - Pass params from Deploy-Accelerator and Test-AcceleratorRequirement through Test-Tooling to Test-NetworkConnectivity - Remove hardcoded MaxRetryCount 0 and TimeoutSec 10 from network connectivity checks
jtracey93
approved these changes
Mar 25, 2026
github-project-automation
bot
moved this from To triage
to Done
in Azure Landing Zone Issues & PRs Triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a new
Invoke-HttpRequestWithRetrycmdlet that centralizes HTTP retry logic for transient errors (408, 429, 500, 502, 503, 504) and refactors existing callers to use it.Changes
Invoke-HttpRequestWithRetryinPrivate/Shared— wrapsInvoke-WebRequestwith configurable retry count, interval, and transient status code handlingInvoke-GitHubApiRequestto delegate retry logic to the new shared cmdlet instead of implementing its own retry loopTest-NetworkConnectivityto useInvoke-HttpRequestWithRetryinstead of callingInvoke-WebRequestdirectlyGet-TerraformToolto useInvoke-HttpRequestWithRetryfor HashiCorp API calls and file downloadsInvoke-HttpRequestWithRetryinstead ofInvoke-WebRequestBenefits