refactor: extract Terraform scenarios to JSON config and add SMB scenarios#531
Open
jaredfholgate wants to merge 2 commits intomainfrom
Open
refactor: extract Terraform scenarios to JSON config and add SMB scenarios#531jaredfholgate wants to merge 2 commits intomainfrom
jaredfholgate wants to merge 2 commits intomainfrom
Conversation
github-project-automation
bot
moved this to To triage
in Azure Landing Zone Issues & PRs Triage
…der for nested keys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Azure/Azure-Landing-Zones#4095
Extract the hardcoded Terraform scenario options from
Request-AcceleratorConfigurationInput.ps1into a dedicatedTerraformScenarios.jsonconfig file, making it easier to add, remove, or update scenarios without modifying PowerShell code.Changes
TerraformScenarios.json- JSON array of scenario objects withlabelandvaluepropertiesRequest-AcceleratorConfigurationInput.ps1- loads scenarios from the JSON file viaConvertFrom-Jsoninstead of inline array