Draft
Conversation
Co-authored-by: romanlutz <10245648+romanlutz@users.noreply.github.com>
Co-authored-by: romanlutz <10245648+romanlutz@users.noreply.github.com>
Co-authored-by: romanlutz <10245648+romanlutz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add feature to show ASR by converter type
Add ASR reporting by converter type
Feb 4, 2026
rlundeen2
reviewed
Feb 6, 2026
|
|
||
| # Extract converter types from last_response | ||
| converter_types = [] | ||
| if attack.last_response is not None and attack.last_response.converter_identifiers: |
Contributor
There was a problem hiding this comment.
we have so many things to filter on, I'm wondering if we want to go this route or something more general. E.g. filtering on any ConverterIdentifier field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds converter type grouping to attack result analytics. Enables comparing effectiveness of different converters (Base64, ROT13, translation, etc.) across attacks.
Changes
pyrit/analytics/result_analysis.py: Extendedanalyze_results()to extract converter class names fromAttackResult.last_response.converter_identifiersand compute stats per converter type. Returns new"By_converter_type"dict alongside existing groupings.tests/unit/analytics/test_result_analysis.py: Added 5 tests covering no-converter tracking, single/multiple converters per attack, and undetermined outcomes. Addedmake_converter()helper to reduce duplication.Behavior
Attacks without converters tracked as
"no_converter". Pipeline attacks with multiple converters contribute to each converter's stats independently.Non-breaking change - preserves existing return structure.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
astral.sh/usr/bin/curl curl -LsSf REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.