upstreamable: resourceMap: group unscheduled pods in node view#493
Merged
gambtho merged 1 commit intoAzure:headlamp-downstreamfrom Mar 25, 2026
Merged
Conversation
10 tasks
14a37f2 to
3212591
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Map tab “Group by Node” view so Pods without spec.nodeName appear as a visible “Unscheduled” group, and avoids linking that group to a nonexistent K8s Node object.
Changes:
- Node grouping accessor returns an
"Unscheduled"sentinel for Pods missingspec.nodeName - Prevents K8s Node object linking for the Unscheduled group
- Updates/extends unit tests to cover the Unscheduled grouping behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| frontend/src/components/resourceMap/graph/graphGrouping.tsx | Adds “Unscheduled” sentinel grouping and guards K8s Node linking for it |
| frontend/src/components/resourceMap/graph/graphGrouping.test.ts | Updates expectations for node grouping and adds a test for Unscheduled group behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3212591 to
2992061
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sniok
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pods without a
spec.nodeName(e.g. pending due to quota or scheduling failures) were silently ungrouped in the Map tab's "Group by Node" view. This made it impossible to see or troubleshoot unscheduled pods from the Map."Unscheduled"sentinel instead ofundefinedfor pods withoutnodeName, so they appear in a visible groupType of Change
Related Issues
Fixes #492 (partially — Map tab fix only; quota warning is in #494)
Changes Made
graphGrouping.tsx'Unscheduled'for pods withoutnodeName; guard added to skip Node object linking for the Unscheduled groupgraphGrouping.test.tsTesting
npx vitest run graphGrouping)Test Cases
nodeNameare grouped intoNode-Unscheduled(updated existing test)'Unscheduled', no linkedkubeObject, and correct member count (new test)nodeNamecontinue to group correctly under their node (existing, unchanged)Checklist