Skip to content

{Containerapp} revert PR#9636

Closed
Greedygre wants to merge 1 commit intoAzure:mainfrom
Greedygre:xinyu/20260226_revert
Closed

{Containerapp} revert PR#9636
Greedygre wants to merge 1 commit intoAzure:mainfrom
Greedygre:xinyu/20260226_revert

Conversation

@Greedygre
Copy link
Contributor

@Greedygre Greedygre commented Feb 26, 2026


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Revert the PR [containerapp] az containerapp [create/update] --environment-mode WorkloadProfiles Add environmen… which is merged today.
When everything ready, we can merge the related PR and release.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings February 26, 2026 05:23
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Feb 26, 2026

❌Azure CLI Extensions Breaking Change Test
❌containerapp
rule cmd_name rule_message suggest_message
1007 - ParaRemove containerapp env create cmd containerapp env create removed parameter environment_mode please add back parameter environment_mode for cmd containerapp env create
1007 - ParaRemove containerapp env update cmd containerapp env update removed parameter environment_mode please add back parameter environment_mode for cmd containerapp env update

@azure-client-tools-bot-prd
Copy link

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 26, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Contributor

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

…-mode WorkloadProfiles` Add environment mode to `az containerapp` (Azure#9551)"

This reverts commit a4f9739.
@Greedygre Greedygre force-pushed the xinyu/20260226_revert branch from bdbc801 to 565aacd Compare February 26, 2026 05:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts a previous feature that introduced the --environment-mode parameter for Container App environments. The revert removes the new parameter and associated validation logic, restoring the use of the --enable-workload-profiles flag for controlling workload profile behavior.

Changes:

  • Removed --environment-mode parameter from containerapp env create and update commands
  • Removed validation function validate_environment_mode_and_workload_profiles_compatible() and all related logic
  • Deleted test file test_utils.py containing tests for the removed validation function
  • Updated tests to remove ValidationError assertions and use expect_failure=True pattern
  • Removed entire test method test_containerapp_env_environment_mode that tested the reverted feature
  • Updated help documentation examples to use --enable-workload-profiles instead of --environment-mode
  • Removed history entry for the feature from HISTORY.rst

Reviewed changes

Copilot reviewed 10 out of 23 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test_utils.py Complete deletion of unit test file for removed validation function
test_containerapp_workload_profile_commands.py Updated test to use expect_failure=True pattern instead of ValidationError assertion; removed ValidationError import
test_containerapp_env_commands.py Removed entire test method for environment mode feature; minor whitespace issue introduced
custom.py Removed environment_mode parameter from create and update function signatures
containerapp_env_decorator.py Reverted decorator methods: removed environment_mode logic, validation, and getter methods; restored original method naming without underscore prefixes
_utils.py Removed validate_environment_mode_and_workload_profiles_compatible() validation function
_up_utils.py Removed environment_mode parameter from ContainerAppEnvironmentPreviewUp class
_params.py Removed environment_mode argument definition
_help.py Updated examples to use --enable-workload-profiles instead of --environment-mode
HISTORY.rst Removed release note entry for the environment-mode feature
Comments suppressed due to low confidence (1)

src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py:419

  • Trailing whitespace detected. This line should end immediately after the closing parenthesis without any trailing spaces.

@github-actions
Copy link
Contributor

Hi @Greedygre

Release Suggestions

Module: containerapp

  • Update VERSION to 1.3.0b4 in src/containerapp/setup.py

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants