Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @Greedygre, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
…-mode WorkloadProfiles` Add environment mode to `az containerapp` (Azure#9551)" This reverts commit a4f9739.
bdbc801 to
565aacd
Compare
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous feature that introduced the --environment-mode parameter for Container App environments. The revert removes the new parameter and associated validation logic, restoring the use of the --enable-workload-profiles flag for controlling workload profile behavior.
Changes:
- Removed
--environment-modeparameter fromcontainerapp env createandupdatecommands - Removed validation function
validate_environment_mode_and_workload_profiles_compatible()and all related logic - Deleted test file
test_utils.pycontaining tests for the removed validation function - Updated tests to remove
ValidationErrorassertions and useexpect_failure=Truepattern - Removed entire test method
test_containerapp_env_environment_modethat tested the reverted feature - Updated help documentation examples to use
--enable-workload-profilesinstead of--environment-mode - Removed history entry for the feature from HISTORY.rst
Reviewed changes
Copilot reviewed 10 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test_utils.py | Complete deletion of unit test file for removed validation function |
| test_containerapp_workload_profile_commands.py | Updated test to use expect_failure=True pattern instead of ValidationError assertion; removed ValidationError import |
| test_containerapp_env_commands.py | Removed entire test method for environment mode feature; minor whitespace issue introduced |
| custom.py | Removed environment_mode parameter from create and update function signatures |
| containerapp_env_decorator.py | Reverted decorator methods: removed environment_mode logic, validation, and getter methods; restored original method naming without underscore prefixes |
| _utils.py | Removed validate_environment_mode_and_workload_profiles_compatible() validation function |
| _up_utils.py | Removed environment_mode parameter from ContainerAppEnvironmentPreviewUp class |
| _params.py | Removed environment_mode argument definition |
| _help.py | Updated examples to use --enable-workload-profiles instead of --environment-mode |
| HISTORY.rst | Removed release note entry for the environment-mode feature |
Comments suppressed due to low confidence (1)
src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py:419
- Trailing whitespace detected. This line should end immediately after the closing parenthesis without any trailing spaces.
|
Hi @Greedygre Release SuggestionsModule: containerapp
Notes
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Revert the PR [containerapp]
az containerapp [create/update] --environment-mode WorkloadProfilesAdd environmen… which is merged today.When everything ready, we can merge the related PR and release.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.