Skip to content

[SSH] Upgrade ssh proxy version and fix bug in which execution crashes if reading ssh log throws an exception#9639

Open
vthiebaut10 wants to merge 5 commits intoAzure:mainfrom
vthiebaut10:vthiebaut/ssh/bugfixsshlogread
Open

[SSH] Upgrade ssh proxy version and fix bug in which execution crashes if reading ssh log throws an exception#9639
vthiebaut10 wants to merge 5 commits intoAzure:mainfrom
vthiebaut10:vthiebaut/ssh/bugfixsshlogread

Conversation

@vthiebaut10
Copy link
Contributor

Fix: Azure/azure-cli#32756
Upgrade ssh proxy version to latest

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings February 27, 2026 19:51
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Feb 27, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @vthiebaut10,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 27, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Contributor

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ssh Azure CLI extension to use a newer Arc SSH proxy version and hardens SSH stderr log reading to prevent crashes when log reads throw exceptions.

Changes:

  • Bump Arc Connectivity SSH proxy version constant.
  • Route SSH log scanning through a new _read_ssh_log_lines helper to tolerate exceptions from stderr.readline().
  • Add unit tests covering log scanning behavior and the new log-reading helper.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/ssh/azext_ssh/ssh_utils.py Adds _read_ssh_log_lines and uses it while scanning ssh/sshproxy logs.
src/ssh/azext_ssh/tests/latest/test_ssh_utils.py Adds tests for common-error log scanning and _read_ssh_log_lines behavior.
src/ssh/azext_ssh/constants.py Upgrades CLIENT_PROXY_VERSION to the new proxy build.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2026

Hi @vthiebaut10

Release Suggestions

Module: ssh

  • Update VERSION to 2.1.0 in src/ssh/setup.py

Notes

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 28, 2026

Please fix CI issues

@vthiebaut10
Copy link
Contributor Author

@yonzhan CI errors fixed. @yanzhudd Can you review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"az ssh arc" command crashes with an utf-8 decoding error when ssh puts corrupted outputs

4 participants