[SSH] Upgrade ssh proxy version and fix bug in which execution crashes if reading ssh log throws an exception#9639
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @vthiebaut10, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Pull request overview
Updates the ssh Azure CLI extension to use a newer Arc SSH proxy version and hardens SSH stderr log reading to prevent crashes when log reads throw exceptions.
Changes:
- Bump Arc Connectivity SSH proxy version constant.
- Route SSH log scanning through a new
_read_ssh_log_lineshelper to tolerate exceptions fromstderr.readline(). - Add unit tests covering log scanning behavior and the new log-reading helper.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/ssh/azext_ssh/ssh_utils.py |
Adds _read_ssh_log_lines and uses it while scanning ssh/sshproxy logs. |
src/ssh/azext_ssh/tests/latest/test_ssh_utils.py |
Adds tests for common-error log scanning and _read_ssh_log_lines behavior. |
src/ssh/azext_ssh/constants.py |
Upgrades CLIENT_PROXY_VERSION to the new proxy build. |
|
Hi @vthiebaut10 Release SuggestionsModule: ssh
Notes
|
|
Please fix CI issues |
Fix: Azure/azure-cli#32756
Upgrade ssh proxy version to latest
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.