Skip to content

{edge-action}ix swap-default LRO poller NoneType error and add tests#9650

Merged
necusjz merged 2 commits intoAzure:mainfrom
tundwed:fix/swap-default-poller
Mar 6, 2026
Merged

{edge-action}ix swap-default LRO poller NoneType error and add tests#9650
necusjz merged 2 commits intoAzure:mainfrom
tundwed:fix/swap-default-poller

Conversation

@tundwed
Copy link
Member

@tundwed tundwed commented Mar 5, 2026

  • Fix swap-default command failing with 'TypeError: NoneType object is not callable' by replacing None with self.on_200 as the deserialization callback for the 202 LRO response handler
  • Add swap-default test verifying default version changes correctly
  • Re-enable execution filter CRUD test with code deployment prerequisite
  • Bump version to 1.0.0b4

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az edge-action

General Guidelines

  • [x ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [x ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [x ] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

- Fix swap-default command failing with 'TypeError: NoneType object is not
  callable' by replacing None with self.on_200 as the deserialization callback
  for the 202 LRO response handler
- Add swap-default test verifying default version changes correctly
- Re-enable execution filter CRUD test with code deployment prerequisite
- Bump version to 1.0.0b4
Copilot AI review requested due to automatic review settings March 5, 2026 01:05
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Mar 5, 2026

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 5, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2026

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the edge-action Azure CLI extension to fix the version swap-default long-running operation (LRO) poller callback bug and expands scenario coverage around version default swapping and execution filter operations.

Changes:

  • Fix swap-default LRO polling by providing a non-None deserialization callback for 202 responses.
  • Add/enable scenario tests for version swap-default and re-enable execution-filter test with a code-deployment prerequisite.
  • Bump extension version to 1.0.0b4 and document changes in HISTORY.rst.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/edge-action/azext_edge_action/aaz/latest/edge_action/version/_swap_default.py Fixes the LRO poller NoneType callback error by using self.on_200 and defining a no-op handler.
src/edge-action/azext_edge_action/tests/latest/test_edge_action.py Adds a swap-default scenario test and re-enables execution-filter scenario coverage with required version code deployment.
src/edge-action/azext_edge_action/tests/latest/recordings/test_edge_action_execution_filter_crud.yaml Adds/updates recording to support the re-enabled execution-filter scenario test.
src/edge-action/setup.py Bumps the extension version to 1.0.0b4.
src/edge-action/HISTORY.rst Adds release notes for 1.0.0b4.

@yonzhan yonzhan requested a review from necusjz March 5, 2026 02:51
@yonzhan yonzhan requested review from jsntcy and kairu-ms March 5, 2026 02:52
@necusjz
Copy link
Member

necusjz commented Mar 6, 2026

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz necusjz merged commit d4d28cb into Azure:main Mar 6, 2026
24 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Mar 6, 2026

[Release] Update index.json for extension [ edge-action-1.0.0b4 ] : https://dev.azure.com/msazure/One/_build/results?buildId=155665326&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants