{edge-action}ix swap-default LRO poller NoneType error and add tests#9650
{edge-action}ix swap-default LRO poller NoneType error and add tests#9650necusjz merged 2 commits intoAzure:mainfrom
Conversation
- Fix swap-default command failing with 'TypeError: NoneType object is not callable' by replacing None with self.on_200 as the deserialization callback for the 202 LRO response handler - Add swap-default test verifying default version changes correctly - Re-enable execution filter CRUD test with code deployment prerequisite - Bump version to 1.0.0b4
️✔️Azure CLI Extensions Breaking Change Test
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull request overview
This PR updates the edge-action Azure CLI extension to fix the version swap-default long-running operation (LRO) poller callback bug and expands scenario coverage around version default swapping and execution filter operations.
Changes:
- Fix
swap-defaultLRO polling by providing a non-Nonedeserialization callback for 202 responses. - Add/enable scenario tests for
version swap-defaultand re-enable execution-filter test with a code-deployment prerequisite. - Bump extension version to
1.0.0b4and document changes inHISTORY.rst.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/edge-action/azext_edge_action/aaz/latest/edge_action/version/_swap_default.py |
Fixes the LRO poller NoneType callback error by using self.on_200 and defining a no-op handler. |
src/edge-action/azext_edge_action/tests/latest/test_edge_action.py |
Adds a swap-default scenario test and re-enables execution-filter scenario coverage with required version code deployment. |
src/edge-action/azext_edge_action/tests/latest/recordings/test_edge_action_execution_filter_crud.yaml |
Adds/updates recording to support the re-enabled execution-filter scenario test. |
src/edge-action/setup.py |
Bumps the extension version to 1.0.0b4. |
src/edge-action/HISTORY.rst |
Adds release notes for 1.0.0b4. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ edge-action-1.0.0b4 ] : https://dev.azure.com/msazure/One/_build/results?buildId=155665326&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az edge-action
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.