Skip to content

[Redisenterprise] az redisenterprise database wait: Fix schema buiding issue#9654

Open
ReaNAiveD wants to merge 1 commit intoAzure:mainfrom
ReaNAiveD:fix-redisenterprise-wait
Open

[Redisenterprise] az redisenterprise database wait: Fix schema buiding issue#9654
ReaNAiveD wants to merge 1 commit intoAzure:mainfrom
ReaNAiveD:fix-redisenterprise-wait

Conversation

@ReaNAiveD
Copy link
Member

The cluster-level Wait was imported as _DatabaseWait, overwriting the database-level Wait import. This caused DatabaseWait to inherit the wrong base class, making its _build_arguments_schema customization operate on a non-existing database_name parameter.

Renamed the alias to _ClusterWait to match sibling imports (_ClusterList, _ClusterShow).

image

This fix is to unblock the Test Extension Loading pipeline step which are sensitive to import resolution order.

Note: The step should fail but succeed due to another known issue.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az redisenterprise database wait --help

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

The cluster-level Wait command (from .aaz.latest.redisenterprise) was
imported as _DatabaseWait, overwriting the earlier database-level Wait
import (from .aaz.latest.redisenterprise.database). This caused the
DatabaseWait class to inherit from the cluster-level Wait instead of
the database-level Wait, so the customization logic in
_build_arguments_schema operated on a non-existing database_name
parameter schema.

Rename the cluster-level import alias from _DatabaseWait to
_ClusterWait to match the naming convention of its sibling imports
(_ClusterList, _ClusterShow).
Copilot AI review requested due to automatic review settings March 6, 2026 05:01
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Mar 6, 2026

❌Azure CLI Extensions Breaking Change Test
❌redisenterprise
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate redisenterprise database wait cmd redisenterprise database wait update parameter cluster_name: updated property options from ['--cluster-name', '--name', '-n'] to ['--cluster-name'] please change property options from ['--cluster-name'] to ['--cluster-name', '--name', '-n'] for parameter cluster_name of cmd redisenterprise database wait

@azure-client-tools-bot-prd
Copy link

Hi @ReaNAiveD,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 6, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an import alias collision in the redisenterprise extension that caused az redisenterprise database wait to inherit the wrong AAZ base command class, breaking _build_arguments_schema customization for database_name.

Changes:

  • Renamed the cluster-level Wait import alias from _DatabaseWait to _ClusterWait to avoid overwriting the database-level _DatabaseWait.

from .aaz.latest.redisenterprise import List as _ClusterList
from .aaz.latest.redisenterprise import Show as _ClusterShow
from .aaz.latest.redisenterprise import Wait as _DatabaseWait
from .aaz.latest.redisenterprise import Wait as _ClusterWait
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_ClusterWait is imported but not referenced anywhere in this module. If azdev style/pylint is run, this will typically trigger an unused-import failure. Consider removing this import, or explicitly suppressing the warning only if it’s intentionally kept for side effects (which would be unusual for an import from the AAZ command layer).

Suggested change
from .aaz.latest.redisenterprise import Wait as _ClusterWait

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

Hi @ReaNAiveD

Release Suggestions

Module: redisenterprise

  • Please log updates into to src/redisenterprise/HISTORY.rst
  • Update VERSION to 2.0.0 in src/redisenterprise/setup.py

Notes

@yonzhan yonzhan assigned calvinhzy and unassigned evelyn-ys Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants