Skip to content

[ACR] add breaking change message#9656

Closed
nguyenm2151 wants to merge 20 commits intoAzure:mainfrom
nguyenm2151:nguyenma/breakingchange
Closed

[ACR] add breaking change message#9656
nguyenm2151 wants to merge 20 commits intoAzure:mainfrom
nguyenm2151:nguyenma/breakingchange

Conversation

@nguyenm2151
Copy link


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings March 6, 2026 17:30
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 6, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a breaking-change announcement to the acrtransfer Azure CLI extension so users are notified about a forthcoming new required parameter for ACR pipeline creation commands.

Changes:

  • Register logic breaking-change announcements for acr export-pipeline create and acr import-pipeline create.
  • Bump extension version to 1.1.1b1 and add corresponding HISTORY.rst entry.
  • Add initial (placeholder) test package structure and a scenario test stub.

Reviewed changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/acrtransfer/setup.py Bumps extension version to 1.1.1b1.
src/acrtransfer/HISTORY.rst Adds release notes entry for the breaking change announcement.
src/acrtransfer/azext_acrtransfer/_breaking_change.py Registers breaking change notifications for the two pipeline create commands.
src/acrtransfer/azext_acrtransfer/__init__.py Imports breaking-change registration module so it runs at load time.
src/acrtransfer/azext_acrtransfer/tests/__init__.py Adds test package initializer.
src/acrtransfer/azext_acrtransfer/tests/latest/__init__.py Adds latest test package initializer.
src/acrtransfer/azext_acrtransfer/tests/latest/test_acrtransfer_scenario.py Adds a placeholder ScenarioTest class for future tests.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

@nguyenm2151
Copy link
Author

/azp run

@nguyenm2151 nguyenm2151 closed this Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants