[ACR] add breaking change message#9656
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull request overview
Adds a breaking-change announcement to the acrtransfer Azure CLI extension so users are notified about a forthcoming new required parameter for ACR pipeline creation commands.
Changes:
- Register logic breaking-change announcements for
acr export-pipeline createandacr import-pipeline create. - Bump extension version to
1.1.1b1and add correspondingHISTORY.rstentry. - Add initial (placeholder) test package structure and a scenario test stub.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/acrtransfer/setup.py |
Bumps extension version to 1.1.1b1. |
src/acrtransfer/HISTORY.rst |
Adds release notes entry for the breaking change announcement. |
src/acrtransfer/azext_acrtransfer/_breaking_change.py |
Registers breaking change notifications for the two pipeline create commands. |
src/acrtransfer/azext_acrtransfer/__init__.py |
Imports breaking-change registration module so it runs at load time. |
src/acrtransfer/azext_acrtransfer/tests/__init__.py |
Adds test package initializer. |
src/acrtransfer/azext_acrtransfer/tests/latest/__init__.py |
Adds latest test package initializer. |
src/acrtransfer/azext_acrtransfer/tests/latest/test_acrtransfer_scenario.py |
Adds a placeholder ScenarioTest class for future tests. |
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…151/azure-cli-extensions into nguyenma/breakingchange
|
/azp run |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.