[DNM] Adding new version 1.12.3 to revert to last known good version (1.11.9)#9657
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @han-sogawa-microsoft, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
There was a problem hiding this comment.
Pull request overview
Adds an entry to the extension index intended to introduce stack-hci-vm version 1.12.3 as a rollback to the last known good 1.11.9.
Changes:
- Updates
src/index.jsonto include a newstack-hci-vmentry labeled1.12.3 - Points the new entry at the existing
1.11.9wheel artifact (URL/filename/digest)
| { | ||
| "downloadUrl": "https://hciarcvmsstorage.z13.web.core.windows.net/cli-extensions/stack_hci_vm-1.11.9-py3-none-any.whl", | ||
| "filename": "stack_hci_vm-1.11.9-py3-none-any.whl", | ||
| "metadata": { | ||
| "azext.minCliCoreVersion": "2.15.0", | ||
| "classifiers": [ | ||
| "Development Status :: 4 - Beta", | ||
| "Intended Audience :: Developers", | ||
| "Intended Audience :: System Administrators", | ||
| "Programming Language :: Python", | ||
| "Programming Language :: Python :: 3", | ||
| "Programming Language :: Python :: 3.6", | ||
| "Programming Language :: Python :: 3.7", | ||
| "Programming Language :: Python :: 3.8", | ||
| "License :: OSI Approved :: MIT License" | ||
| ], | ||
| "extensions": { | ||
| "python.details": { | ||
| "contacts": [ | ||
| { | ||
| "email": "azpycli@microsoft.com", | ||
| "name": "Microsoft Corporation", | ||
| "role": "author" | ||
| } | ||
| ], | ||
| "document_names": { | ||
| "description": "DESCRIPTION.rst" | ||
| }, | ||
| "project_urls": { | ||
| "Home": "https://github.com/Azure/azure-cli-extensions/tree/master/src/stack-hci-vm" | ||
| } | ||
| } | ||
| }, | ||
| "generator": "bdist_wheel (0.30.0)", | ||
| "license": "MIT", | ||
| "metadata_version": "2.0", | ||
| "name": "stack-hci-vm", | ||
| "summary": "Microsoft Azure Command-Line Tools Stack-HCi-VM Extension", | ||
| "version": "1.12.3" | ||
| }, | ||
| "sha256Digest": "317e6b3ce0117bdafd92094ccfe47c12732b67f9f12fd2022b98735c45978d69" |
There was a problem hiding this comment.
The added entry claims version 1.12.3, but its downloadUrl/filename and sha256Digest point to the existing 1.11.9 wheel (and 1.11.9 already appears earlier in this list). This creates inconsistent metadata and will likely cause clients to install/report the wrong extension version. Publish/reference a real 1.12.3 wheel (URL/filename/digest) or keep the version as 1.11.9 and avoid duplicating the existing entry.
| }, | ||
| { | ||
| "downloadUrl": "https://hciarcvmsstorage.z13.web.core.windows.net/cli-extensions/stack_hci_vm-1.11.9-py3-none-any.whl", | ||
| "filename": "stack_hci_vm-1.11.9-py3-none-any.whl", | ||
| "metadata": { |
There was a problem hiding this comment.
This PR edits src/index.json directly, but the PR description/template explicitly says index.json is updated automatically after merge and should not be modified in the PR. If that process still applies, revert this index.json change and instead update the extension's setup.py/HISTORY.rst; the publishing pipeline will generate the index update.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.