[AKS] az aks update: Add --disable-http-proxy and --enable-http-proxy options#32996
Open
[AKS] az aks update: Add --disable-http-proxy and --enable-http-proxy options#32996
az aks update: Add --disable-http-proxy and --enable-http-proxy options#32996Conversation
❌AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks update | cmd aks update added parameter disable_http_proxy |
||
| aks update | cmd aks update added parameter enable_http_proxy |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
FumingZhang,
yanzhudd,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
Auto-Assign
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds GA support for toggling an AKS cluster’s HTTP proxy configuration on/off via az aks update by introducing --disable-http-proxy and --enable-http-proxy.
Changes:
- Add new CLI flags (
--disable-http-proxy,--enable-http-proxy) toaz aks updateparameters and help. - Implement update-time logic to toggle
managedCluster.httpProxyConfig.enabled. - Extend unit and live scenario tests to cover the new toggling behavior.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py |
Adds context getters and update logic to toggle HTTP proxy enabled/disabled during aks update. |
src/azure-cli/azure/cli/command_modules/acs/custom.py |
Extends aks_update signature so the new flags flow into the decorator raw parameters. |
src/azure-cli/azure/cli/command_modules/acs/_params.py |
Wires new CLI arguments for aks update. |
src/azure-cli/azure/cli/command_modules/acs/_help.py |
Documents the new --disable-http-proxy / --enable-http-proxy options. |
src/azure-cli/azure/cli/command_modules/acs/linter_exclusions.yml |
Excludes the new long option names from the option-length linter rule. |
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py |
Adds unit tests for the new enable/disable update behavior. |
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py |
Adds live-only scenario coverage for toggling HTTP proxy state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_managed_cluster_decorator.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 32996 in repo Azure/azure-cli |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
FumingZhang
reviewed
Mar 24, 2026
Member
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
Queued live test to validate the change.
Member
Test failed with error
|
Author
|
@FumingZhang this error seems transient and unrelated to my changes, can we queue all tests again please? Thanks |
Author
|
@FumingZhang I ran the live test locally on dev branch and still had the same failure. I believe this is unrelated to my changes. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Re-queued live test |
Member
If so, please figure out the root cause and fix the test case accordingly. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Author
|
@FumingZhang I believe I fixed the issue with the test with my latest commit. Please queue tests again when you are available. Thank you |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
Re-queued live test |
Member
The test failed with error
Please ensure the test passes in the live test pipeline. You can click the "Run New" button and use the current settings to rerun the pipeline. @mxj220 |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Author
|
@FumingZhang how much longer until CLI changes are closed? I confirmed successful live tests and now just need to have the unit tests run to merge this change. https://dev.azure.com/msazure/CloudNativeCompute/_build/results?buildId=158509772&view=results Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az aks update --enable-http-proxy
az aks update --disable-http-proxy
Description
This PR adds the ability to enable and disable HTTP proxy via
az aks update. This functionality was available in preview and has been added to GA.Testing Guide
History Notes
[AKS]
az aks update: Add--disable-http-proxyand--enable-http-proxyoptionsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.